mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-04-24 14:53:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

Initialize py_type_printers in ext_lang_type_printers

Browse Source 
When running gdb in the build directory without passing
--data-directory, I noticed I could provoke a crash by:

    $ ./gdb -nx ./gdb
    (gdb) ptype/o struct dwarf2_per_objfile

... and then trying to "q" out at the pagination prompt.

valgrind complained about an uninitialized use of py_type_printers.
Initializing this member fixes the bug.

I believe this bug can occur even when the gdb Python libraries are
available, for example if get_type_recognizers fails.

Tested by hand on x86-64 Fedora 26.  No test case because it seemed
difficult to guarantee failures.

gdb/ChangeLog
2018-05-17  Tom Tromey  <tom@tromey.com>

	* extension.h (struct ext_lang_type_printers) <py_type_printers>:
	Initialize.
This commit is contained in:
Tom Tromey 2018-05-16 11:39:09 -06:00
parent 1a87f0eedc
commit fe10fe3131
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2018-05-17 Tom Tromey <tom@tromey.com>
* extension.h (struct ext_lang_type_printers) <py_type_printers>:
Initialize.
2018-05-16 Maciej W. Rozycki <macro@mips.com>
PR gdb/22286

2
gdb/extension.h
View File

@ -152,7 +152,7 @@ struct ext_lang_type_printers
DISABLE_COPY_AND_ASSIGN (ext_lang_type_printers);
/* Type-printers from Python. */
void *py_type_printers;
void *py_type_printers = nullptr;
};
/* The return code for some API calls. */