2
0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-02-17 13:10:12 +08:00

x86/Intel: adjustment to restricted suffix derivation

In "x86/Intel: restrict suffix derivation" I think I screwed up
slightly, bringing a piece of code out of sync with its comment, and
resulting in a suffix potentially being derived when one isn't needed.
This commit is contained in:
Jan Beulich 2022-11-30 09:10:17 +01:00
parent 4943d587f9
commit fcaf78fe4d

View File

@ -841,11 +841,16 @@ i386_intel_operand (char *operand_string, int got_a_float)
abort ();
}
/* We can skip templates with swappable operands here, as one
operand will be a register, which operand size can be
determined from. */
if (t->opcode_modifier.d)
continue;
/* In a few cases suffixes are permitted, but we can nevertheless
derive that these aren't going to be needed. This is only of
interest for insns using ModR/M, plus we can skip templates with
swappable operands here (simplifying subsequent logic). */
if (!t->opcode_modifier.modrm || t->opcode_modifier.d)
interest for insns using ModR/M. */
if (!t->opcode_modifier.modrm)
break;
if (!t->operand_types[op].bitfield.baseindex)