mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-02-23 13:21:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix interp::m_name resource leak found by Coverity

Browse Source 
This commit fixes a resource leak found by Coverity, where interp's
constructor allocated memory for m_name that interp's destructor did
not free.

gdb/ChangeLog:

	* interps.h (interp::m_name): Make private and mutable.
	* interps.c (interp::~interp): Free m_name.
This commit is contained in:
Gary Benson 2018-10-11 10:19:26 +01:00
parent a9597defaf
commit fbe61a3661
3 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2018-10-11 Gary Benson <gbenson@redhat.com>
* interps.h (interp::m_name): Make private and mutable.
* interps.c (interp::~interp): Free m_name.
2018-10-10 Sergio Durigan Junior <sergiodj@redhat.com>
Simon Marchi <simark@simark.ca>

4
gdb/interps.c
View File

@ -84,7 +84,9 @@ interp::interp (const char *name)
}
interp::~interp ()
{}
{
xfree (m_name);
}
/* An interpreter factory. Maps an interpreter name to the factory
function that instantiates an interpreter by that name. */

4
gdb/interps.h
View File

@ -80,10 +80,12 @@ class interp
}
/* This is the name in "-i=" and "set interpreter". */
const char *m_name;
private:
char *m_name;
/* Interpreters are stored in a linked list, this is the next
one... */
public:
struct interp *next;
/* Has the init method been run? */