mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-01-06 12:09:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

ubsan: ns32k: left shift cannot be represented in type 'int'

Browse Source 
* ns32k-dis.c (bit_extract): Use unsigned arithmetic.
	(bit_extract_simple, sign_extend): Likewise.
This commit is contained in:
Alan Modra 2019-12-11 08:34:57 +10:30
parent 96f1f60460
commit fb4cb4e26d
2 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
opcodes/ChangeLog
View File

@ -1,3 +1,8 @@
2019-12-11 Alan Modra <amodra@gmail.com>
* ns32k-dis.c (bit_extract): Use unsigned arithmetic.
(bit_extract_simple, sign_extend): Likewise.
2019-12-11 Alan Modra <amodra@gmail.com>
* nios2-dis.c (nios2_print_insn_arg): Use 1u << 31.

16
opcodes/ns32k-dis.c
View File

@ -262,8 +262,8 @@ list_search (int reg_value, const struct ns32k_option *optionP, char *result)
static int
bit_extract (bfd_byte *buffer, int offset, int count)
{
int result;
int bit;
unsigned int result;
unsigned int bit;
if (offset < 0 || count < 0)
return 0;
@ -291,8 +291,8 @@ bit_extract (bfd_byte *buffer, int offset, int count)
static int
bit_extract_simple (bfd_byte *buffer, int offset, int count)
{
int result;
int bit;
unsigned int result;
unsigned int bit;
if (offset < 0 || count < 0)
return 0;
@ -325,12 +325,10 @@ bit_copy (bfd_byte *buffer, int offset, int count, char *to)
}
static int
sign_extend (int value, int bits)
sign_extend (unsigned int value, unsigned int bits)
{
value = value & ((1 << bits) - 1);
return (value & (1 << (bits - 1))
? value | (~((1 << bits) - 1))
: value);
unsigned int sign = 1u << bits;
return ((value & (sign - 1)) ^ sign) - sign;
}
static void