mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-02-05 12:53:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Re: Update objcopy's --section-alignment option

Browse Source 
ubsan: left shift of 1 by 31 places cannot be represented in type 'int'

	* objcopy.c (setup_section): Avoid undefined behaviour when
	checking vma and lma for alignment.
This commit is contained in:
Alan Modra 2024-04-04 20:48:14 +10:30
parent 1bc2544b89
commit fab240554b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
binutils/objcopy.c
View File

@ -4340,7 +4340,7 @@ setup_section (bfd *ibfd, sec_ptr isection, void *obfdarg)
and the VMA was not set by the user
and the section does not have relocations associated with it
then warn the user. */
if (osection->vma & ((1 << alignment) - 1)
if ((osection->vma & (((bfd_vma) 1 << alignment) - 1)) != 0
&& alignment != bfd_section_alignment (isection)
&& change_section_address == 0
&& ! vma_set_by_user
@ -4352,7 +4352,7 @@ setup_section (bfd *ibfd, sec_ptr isection, void *obfdarg)
/* Similar check for a non-aligned LMA.
FIXME: Since this is only an LMA, maybe it does not matter if
it is not aligned ? */
if (osection->lma & ((1 << alignment) - 1)
if ((osection->lma & (((bfd_vma) 1 << alignment) - 1)) != 0
&& alignment != bfd_section_alignment (isection)
&& change_section_address == 0
&& ! lma_set_by_user