mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-12-09 04:21:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix seg-fault in the binutils utilities when reading a corrupt input file.

Browse Source 
PR binutils/20905
	* peicode.h (pe_ILF_object_p): Use strnlen to avoid running over
	the end of the string buffer.
This commit is contained in:
Nick Clifton 2016-12-05 16:34:45 +00:00
parent 406bd128db
commit fa6631b4ee
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bfd/ChangeLog
View File

@ -5,6 +5,10 @@
2016-12-05 Nick Clifton <nickc@redhat.com>
PR binutils/20905
* peicode.h (pe_ILF_object_p): Use strnlen to avoid running over
the end of the string buffer.
PR binutils/20907
* peicode.h (pe_ILF_build_a_bfd): Replace abort with error return.

3
bfd/peicode.h
View File

@ -1269,7 +1269,8 @@ pe_ILF_object_p (bfd * abfd)
}
symbol_name = (char *) ptr;
source_dll = symbol_name + strlen (symbol_name) + 1;
/* See PR 20905 for an example of where the strnlen is necessary. */
source_dll = symbol_name + strnlen (symbol_name, size - 1) + 1;
/* Verify that the strings are null terminated. */
if (ptr[size - 1] != 0