mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-21 01:12:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

objcopy memory leaks after errors

Browse Source 
These aren't important at all, but tidy them in case they obscure
other more important leaks.

	* objcopy (copy_file): Close input bfd after errors.
This commit is contained in:
Alan Modra 2023-06-06 09:50:56 +09:30
parent d5b46032b8
commit f5c0d77088
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
binutils/objcopy.c
View File

@ -3821,6 +3821,8 @@ copy_file (const char *input_filename, const char *output_filename, int ofd,
if (ibfd == NULL || bfd_stat (ibfd, in_stat) != 0)
{
bfd_nonfatal_message (input_filename, NULL, NULL, NULL);
if (ibfd != NULL)
bfd_close (ibfd);
status = 1;
return;
}
@ -3890,6 +3892,7 @@ copy_file (const char *input_filename, const char *output_filename, int ofd,
{
close (ofd);
bfd_nonfatal_message (output_filename, NULL, NULL, NULL);
bfd_close (ibfd);
status = 1;
return;
}
@ -3922,6 +3925,7 @@ copy_file (const char *input_filename, const char *output_filename, int ofd,
{
close (ofd);
bfd_nonfatal_message (output_filename, NULL, NULL, NULL);
bfd_close (ibfd);
status = 1;
return;
}
@ -3970,6 +3974,7 @@ copy_file (const char *input_filename, const char *output_filename, int ofd,
if (core_error == bfd_error_file_ambiguously_recognized)
list_matching_formats (core_matching);
bfd_close (ibfd);
status = 1;
}
}