mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-03-07 13:39:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdb/arch: assert that X86_XSTATE_MPX is not set for x32

Browse Source 
While trying to merge this commit:

  commit 4bb20a6244
  Date:   Wed Mar 20 04:13:18 2024 -0700

      gdbserver: Clear X86_XSTATE_MPX bits in xcr0 on x32

With this patch series of mine:

  https://inbox.sourceware.org/gdb-patches/cover.1706801009.git.aburgess@redhat.com

I worried that there could be other paths that could result in an xcr0
value that has X86_XSTATE_MPX set in x32 mode.  As everyone eventually
calls amd64_create_target_description to build their target
description, I figured we could assert in here that if X86_XSTATE_MPX
is set then we should not be an x32 target, this should uncover any
other bugs in this area.

I'm not currently able to build/run any x32 binaries, so I have no way
to test this.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31511
This commit is contained in:
Andrew Burgess 2024-03-23 16:17:36 +00:00
parent cd9b374ffe
commit efba976d97
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/arch/amd64.c
View File

@ -66,8 +66,12 @@ amd64_create_target_description (uint64_t xcr0, bool is_x32, bool is_linux,
if (xcr0 & X86_XSTATE_AVX)
regnum = create_feature_i386_64bit_avx (tdesc.get (), regnum);
if ((xcr0 & X86_XSTATE_MPX) && !is_x32)
regnum = create_feature_i386_64bit_mpx (tdesc.get (), regnum);
if (xcr0 & X86_XSTATE_MPX)
{
/* MPX is not available on x32. */
gdb_assert (!is_x32);
regnum = create_feature_i386_64bit_mpx (tdesc.get (), regnum);
}
if (xcr0 & X86_XSTATE_AVX512)
regnum = create_feature_i386_64bit_avx512 (tdesc.get (), regnum);