mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-01-18 12:24:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdbserver: Fix vAttach response when attaching is not supported

Browse Source 
handle_v_attach calls attach_inferior, which says:

  "return -1 if attaching is unsupported, 0 if it succeeded, and call
  error() otherwise."

So if attach_inferior return != 0, we have the unsupported case,
meaning we should return the empty packet instead of an error.

In practice, this shouldn't trigger, as vAttach support is supposed to
be reported via qSupported.  But it doesn't hurt to be pedantic here.

Change-Id: I99cce6fa678f2370571e6bca0657451300956127
Approved-By: Tom Tromey <tom@tromey.com>
This commit is contained in:
Pedro Alves 2024-04-19 14:37:56 +01:00
parent f1fc8dc2dc
commit ef27d39dd2
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdbserver/server.cc
View File

@ -3318,7 +3318,10 @@ handle_v_attach (char *own_buf)
prepare_resume_reply (own_buf, cs.last_ptid, cs.last_status);
}
else
write_enn (own_buf);
{
/* Not supported. */
own_buf[0] = 0;
}
}
catch (const gdb_exception_error &exception)
{