mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-21 01:12:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

* texhex.c (first_phase): Don't fall through into the default

Browse Source 
case.
	(pass_over): Replace abort () calls with return FALSE.  Fix
	buffer overflow.
This commit is contained in:
Jakub Jelinek 2007-01-05 10:12:25 +00:00
parent 8936fcda88
commit ebe8b99135
2 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
bfd/ChangeLog
View File

@ -1,3 +1,10 @@
2007-01-05 Jakub Jelinek <jakub@redhat.com>
* texhex.c (first_phase): Don't fall through into the default
case.
(pass_over): Replace abort () calls with return FALSE. Fix
buffer overflow.
2007-01-04 Jie Zhang <jie.zhang@analog.com>
* elf-eh-frame.c (_bfd_elf_discard_section_eh_frame): Don't set

16
bfd/tekhex.c
View File

@ -436,6 +436,7 @@ first_phase (bfd *abfd, int type, char *src)
if (!getvalue (&src, &val))
return FALSE;
new->symbol.value = val - section->vma;
break;
}
default:
return FALSE;
@ -457,11 +458,10 @@ pass_over (bfd *abfd, bfd_boolean (*func) (bfd *, int, char *))
/* To the front of the file. */
if (bfd_seek (abfd, (file_ptr) 0, SEEK_SET) != 0)
abort ();
return FALSE;
while (! eof)
{
char buffer[MAXCHUNK];
char *src = buffer;
char src[MAXCHUNK];
char type;
/* Find first '%'. */
@ -471,22 +471,24 @@ pass_over (bfd *abfd, bfd_boolean (*func) (bfd *, int, char *))
if (eof)
break;
src++;
/* Fetch the type and the length and the checksum. */
if (bfd_bread (src, (bfd_size_type) 5, abfd) != 5)
abort (); /* FIXME. */
return FALSE;
type = src[2];
if (!ISHEX (src[0]) || !ISHEX (src[1]))
break;
/* Already read five char. */
/* Already read five chars. */
chars_on_line = HEX (src) - 5;
if (chars_on_line >= MAXCHUNK)
return FALSE;
if (bfd_bread (src, (bfd_size_type) chars_on_line, abfd) != chars_on_line)
abort (); /* FIXME. */
return FALSE;
/* Put a null at the end. */
src[chars_on_line] = 0;