mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-27 03:51:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdb/corelow.c: do not try to reopen a file if open failed once

Browse Source 
In the current implementation, core_target::build_file_mappings will try
to locate and open files which were mapped in the process for which the
core dump was produced.  If the file cannot be found or cannot be
opened, GDB will re-try to open it once for each time it was mapped in
the process's address space.

This patch makes it so GDB recognizes that it has already failed to open
a given file once and does not re-try the process for each mapping.

Reviewed-By: John Baldwin <jhb@FreeBSD.org>
Approved-By: Andrew Burgess <aburgess@redhat.com>
This commit is contained in:
Lancelot SIX 2023-05-31 15:04:55 +01:00
parent 0ad504dd46
commit ea70f941f9
1 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
gdb/corelow.c
View File

@ -233,6 +233,16 @@ core_target::build_file_mappings ()
weed out non-file-backed mappings. */
gdb_assert (filename != nullptr);
if (unavailable_paths.find (filename) != unavailable_paths.end ())
{
/* We have already seen some mapping for FILENAME but failed to
find/open the file. There is no point in trying the same
thing again so just record that the range [start, end) is
unavailable. */
m_core_unavailable_mappings.emplace_back (start, end - start);
return;
}
struct bfd *bfd = bfd_map[filename];
if (bfd == nullptr)
{
@ -250,11 +260,10 @@ core_target::build_file_mappings ()
if (expanded_fname == nullptr)
{
m_core_unavailable_mappings.emplace_back (start, end - start);
/* Print just one warning per path. */
if (unavailable_paths.insert (filename).second)
warning (_("Can't open file %s during file-backed mapping "
"note processing"),
filename);
unavailable_paths.insert (filename);
warning (_("Can't open file %s during file-backed mapping "
"note processing"),
filename);
return;
}
@ -263,10 +272,10 @@ core_target::build_file_mappings ()
if (bfd == nullptr || !bfd_check_format (bfd, bfd_object))
{
m_core_unavailable_mappings.emplace_back (start, end - start);
if (unavailable_paths.insert (filename).second)
warning (_("Can't open file %s which was expanded to %s "
"during file-backed mapping note processing"),
filename, expanded_fname.get ());
unavailable_paths.insert (filename);
warning (_("Can't open file %s which was expanded to %s "
"during file-backed mapping note processing"),
filename, expanded_fname.get ());
if (bfd != nullptr)
bfd_close (bfd);