mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-03-07 13:39:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

linux-fork.c: rewrite inf_has_multiple_threads

Browse Source 
There's no need to iterate over all threads of all inferiors here.

gdb/ChangeLog:
2019-03-06  Pedro Alves  <palves@redhat.com>

	* linux-fork.c (inf_has_multiple_thread_cb): Delete.
	(inf_has_multiple_threads): Return 'bool' and rewrite using
	inferior_info::threads().
This commit is contained in:
Pedro Alves 2019-03-06 18:29:19 +00:00
parent 06974e6c05
commit e52c971f17
2 changed files with 15 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2019-03-06 Pedro Alves <palves@redhat.com>
* linux-fork.c (inf_has_multiple_thread_cb): Delete.
(inf_has_multiple_threads): Return 'bool' and rewrite using
inferior_info::threads().
2019-03-06 Pedro Alves <palves@redhat.com>
* linux-fork.c: Include <list>.

29
gdb/linux-fork.c
View File

@ -627,31 +627,20 @@ linux_fork_checkpointing_p (int pid)
return (checkpointing_pid == pid);
}
/* Callback for iterate over threads. Used to check whether
the current inferior is multi-threaded. Returns true as soon
as it sees the second thread of the current inferior. */
static int
inf_has_multiple_thread_cb (struct thread_info *tp, void *data)
{
int *count_p = (int *) data;
if (current_inferior ()->pid == tp->ptid.pid ())
(*count_p)++;
/* Stop the iteration if multiple threads have been detected. */
return *count_p > 1;
}
/* Return true if the current inferior is multi-threaded. */
static int
inf_has_multiple_threads (void)
static bool
inf_has_multiple_threads ()
{
int count = 0;
iterate_over_threads (inf_has_multiple_thread_cb, &count);
return (count > 1);
/* Return true as soon as we see the second thread of the current
inferior. */
for (thread_info *tp ATTRIBUTE_UNUSED : current_inferior ()->threads ())
if (++count > 1)
return true;
return false;
}
static void