mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-12-15 04:31:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdb/python: remove PyObject_IsTrue call in gdbpy_handle_missing_debuginfo

Browse Source 
In this review:

  https://inbox.sourceware.org/gdb-patches/87wmirfzih.fsf@tromey.com

Tom pointed out that using PyObject_IsTrue as I was doing, though
technically fine, at least appears to be missing an error check, and
that it would be better to compare to Py_True directly.  I made that
change in the patch Tom was commenting on, but I'd actually copied
that code from elsewhere in python/python.c, so this commit updates
the original code inline with Tom's review feedback.

There should be no functional change after this commit.

Approved-By: Tom Tromey <tom@tromey.com>
This commit is contained in:
Andrew Burgess 2024-11-10 14:35:22 +00:00
parent 768f23b94f
commit dcf4c48453
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/python/python.c
View File

@ -1810,7 +1810,9 @@ gdbpy_handle_missing_debuginfo (const struct extension_language_defn *extlang,
if (PyBool_Check (pyo_execute_ret.get ()))
{
bool try_again = PyObject_IsTrue (pyo_execute_ret.get ());
/* We know the value is a bool, so it must be either Py_True or
Py_False. Anything else would not get past the above check. */
bool try_again = pyo_execute_ret.get () == Py_True;
return ext_lang_missing_file_result (try_again);
}