mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-01-30 12:44:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

More _bfd_ecoff_locate_line sanity checks

Browse Source 
* ecofflink.c (mk_fdrtab): Discard fdr with negative cpd.
	(lookup_line): Sanity check fdr cbLineOffset and cbLine.
	Sanity check pdr cbLineOffset.
This commit is contained in:
Alan Modra 2023-03-06 10:43:47 +10:30
parent d919194f08
commit d845ea8cd3
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
bfd/ecofflink.c
View File

@ -1742,6 +1742,7 @@ mk_fdrtab (bfd *abfd,
/* Sanity check fdr procedure descriptor pointer. */
long ipdMax = debug_info->symbolic_header.ipdMax;
if (fdr_ptr->ipdFirst >= ipdMax
|| fdr_ptr->cpd < 0
|| fdr_ptr->cpd > ipdMax - fdr_ptr->ipdFirst)
fdr_ptr->cpd = 0;
/* Skip FDRs that have no PDRs. */
@ -2146,12 +2147,20 @@ lookup_line (bfd *abfd,
are stored in a very funky format, which I won't try to
describe. The search is bounded by the end of the FDRs line
number entries. */
line_end = debug_info->line + fdr_ptr->cbLineOffset + fdr_ptr->cbLine;
line_ptr = line_end = debug_info->line;
if (fdr_ptr->cbLineOffset < debug_info->symbolic_header.cbLine
&& fdr_ptr->cbLine <= (debug_info->symbolic_header.cbLine
- fdr_ptr->cbLineOffset)
&& pdr.cbLineOffset <= (debug_info->symbolic_header.cbLine
- fdr_ptr->cbLineOffset))
{
line_end += fdr_ptr->cbLineOffset + fdr_ptr->cbLine;
line_ptr += fdr_ptr->cbLineOffset + pdr.cbLineOffset;
}
/* Make offset relative to procedure entry. */
offset -= pdr.adr - 0x10 * pdr.prof;
lineno = pdr.lnLow;
line_ptr = debug_info->line + fdr_ptr->cbLineOffset + pdr.cbLineOffset;
while (line_ptr < line_end)
{
int delta;