mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-12-09 04:21:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Adjust gdb_continue_to_end for Windows

Browse Source 
On Cygwin, supposely single-threaded programs are always
multi-threaded, due to the extra threads spawned by the Cygwin
runtime.  Because of that, any gdb_continue_to_end call that doesn't
specify "allow_extra" fails, like so:

 (gdb) PASS: gdb.base/langs.exp: show language at main
 continue
 Continuing.
 [Thread 16140.0x1fbc exited with code 0]
 [Thread 16140.0x2458 exited with code 0]
 [Thread 16140.0x3494 exited with code 0]
 [Inferior 1 (process 16140) exited normally]
 (gdb) FAIL: gdb.base/langs.exp: continue until exit at first session (the program exited)

Similarly, with this simple program compiled with MinGW:

 $ cat ~/sleeper.c
 #include <windows.h>

 int main ()
 {
   Sleep (2000);
   return 0;
 }

and with a MinGW GDB, I see:

 (gdb) start
 ...
 (gdb) info threads
   Id   Target Id           Frame
 * 1    Thread 15292.0x3850 main () at /home/alves/sleeper.c:5
   2    Thread 15292.0x3048 0x00007ff9630d2fb7 in ntdll!ZwWaitForWorkViaWorkerFactory () from C:\Windows\SYSTEM32\ntdll.dll
 (gdb) c
 Continuing.
 [Thread 15292.0x3850 exited with code 0]
 [Inferior 1 (process 15292) exited normally]
 (gdb)

This commit adjusts gdb_continue_to_end to expect the thread exited
messages, on Cygwin and MinGW.

Change-Id: I5e410a7252c11cd9ecea632f1e00c2a7fcd69098
Approved-By: Andrew Burgess <aburgess@redhat.com>
This commit is contained in:
Pedro Alves 2024-05-03 17:39:16 +01:00
parent 67fe874896
commit ccdb887584
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
gdb/testsuite/lib/gdb.exp
View File

@ -7471,8 +7471,23 @@ proc gdb_continue_to_end {{mssg ""} {command continue} {allow_extra 0}} {
} else {
set text "continue until exit at $mssg"
}
if {$allow_extra} {
set extra ".*"
} elseif {[istarget *-*-cygwin*] || [istarget *-*-mingw*]} {
# On Windows, even on supposedly single-threaded programs, we
# may see thread exit output when running to end, for threads
# spawned by the runtime. E.g.:
#
# (gdb) continue
# Continuing.
# [Thread 14364.0x21d4 exited with code 0]
# [Thread 14364.0x4374 exited with code 0]
# [Thread 14364.0x3aec exited with code 0]
# [Thread 14364.0x3368 exited with code 0]
# [Inferior 1 (process 14364) exited normally]
#
set extra "(\\\[Thread \[^\r\n\]+ exited with code $::decimal\\\]\r\n)*"
} else {
set extra ""
}