From caa31cfad6c16ffbd5c396f74273fc9e413906f0 Mon Sep 17 00:00:00 2001 From: Nick Clifton Date: Fri, 24 Jan 2020 13:19:48 +0000 Subject: [PATCH] Fix an illegal call to free() when copying a PE format file. PR 25447 * coffgen.c (_bfd_coff_close_and_cleanup): Do not clear the keep syms and keep strings flags as these may have been set in order to prevent a bogus call to free. --- bfd/ChangeLog | 7 +++++++ bfd/coffgen.c | 6 ++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 108276ad6ab..5d8d2cdb9eb 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,10 @@ +2020-01-24 Nick Clifton + + PR 25447 + * coffgen.c (_bfd_coff_close_and_cleanup): Do not clear the keep + syms and keep strings flags as these may have been set in order to + prevent a bogus call to free. + 2020-01-23 Nick Clifton * po/fr.po: Updated French translation. diff --git a/bfd/coffgen.c b/bfd/coffgen.c index 2bfcf1a6b14..3ddd2d89a83 100644 --- a/bfd/coffgen.c +++ b/bfd/coffgen.c @@ -3175,8 +3175,10 @@ _bfd_coff_close_and_cleanup (bfd *abfd) && bfd_family_coff (abfd) && coff_data (abfd) != NULL) { - obj_coff_keep_syms (abfd) = FALSE; - obj_coff_keep_strings (abfd) = FALSE; + /* PR 25447: + Do not clear the keep_syms and keep_strings flags. + These may have been set by pe_ILF_build_a_bfd() indicating + that the syms and strings pointers are not to be freed. */ if (!_bfd_coff_free_symbols (abfd)) return FALSE; }