mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-01-30 12:44:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

* regcache.c (register_valid): Revise comments refering to "Not

Browse Source 
available" and "unavailable".
* frame.c (frame_register_read): Ditto.
* findvar.c (value_of_register): Ditto.
This commit is contained in:
Andrew Cagney 2002-05-15 01:01:56 +00:00
parent c2c01aa78c
commit c97dcfc7b8
4 changed files with 28 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@ -1,3 +1,10 @@
2002-05-14 Andrew Cagney <ac131313@redhat.com>
* regcache.c (register_valid): Revise comments refering to "Not
available" and "unavailable".
* frame.c (frame_register_read): Ditto.
* findvar.c (value_of_register): Ditto.
2002-05-15 Andrew Cagney <cagney@redhat.com>
* Makefile.in (remote_sim_h): Replace remote-sim_h.

7
gdb/findvar.c
View File

@ -308,6 +308,13 @@ value_of_register (int regnum, struct frame_info *frame)
get_saved_register (raw_buffer, &optim, &addr,
frame, regnum, &lval);
/* FIXME: cagney/2002-05-15: This test is just bogus.
It indicates that the target failed to supply a value for a
register because it was "not available" at this time. Problem
is, the target still has the register and so get saved_register()
may be returning a value saved on the stack. */
if (register_cached (regnum) < 0)
return NULL; /* register value not available */

11
gdb/frame.c
View File

@ -157,10 +157,13 @@ frame_register_read (struct frame_info *frame, int regnum, void *myaddr)
get_saved_register (myaddr, &optim, (CORE_ADDR *) NULL, frame,
regnum, (enum lval_type *) NULL);
/* FIXME: cagney/2002-04-10: This test is just bogus. It is no
indication of the validity of the register. The value could
easily be found (on the stack) even though the corresponding
register isn't available. */
/* FIXME: cagney/2002-05-15: This test, is just bogus.
It indicates that the target failed to supply a value for a
register because it was "not available" at this time. Problem
is, the target still has the register and so get saved_register()
may be returning a value saved on the stack. */
if (register_cached (regnum) < 0)
return 0; /* register value not available */

8
gdb/regcache.c
View File

@ -45,7 +45,13 @@ char *registers;
/* REGISTER_VALID is 0 if the register needs to be fetched,
1 if it has been fetched, and
-1 if the register value was not available.
"Not available" means don't try to fetch it again. */
"Not available" indicates that the target is not not able to supply
the register at this state. The register may become available at a
later time (after the next resume). This often occures when GDB is
manipulating a target that contains only a snapshot of the entire
system being debugged - some of the registers in such a system may
not have been saved. */
signed char *register_valid;