mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-21 01:12:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

tekhex: Uninitialised read

Browse Source 
* tekhex.c (pass_over): Check is_eof before reading buffer.
This commit is contained in:
Alan Modra 2020-03-31 14:51:25 +10:30
parent d262797294
commit b3b360dec7
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bfd/ChangeLog
View File

@ -1,3 +1,7 @@
2020-03-31 Alan Modra <amodra@gmail.com>
* tekhex.c (pass_over): Check is_eof before reading buffer.
2020-03-30 Nick Clifton <nickc@redhat.com>
PR binutils/pr25662

2
bfd/tekhex.c
View File

@ -525,7 +525,7 @@ pass_over (bfd *abfd, bfd_boolean (*func) (bfd *, int, char *, char *))
/* Find first '%'. */
is_eof = (bfd_boolean) (bfd_bread (src, (bfd_size_type) 1, abfd) != 1);
while (*src != '%' && !is_eof)
while (!is_eof && *src != '%')
is_eof = (bfd_boolean) (bfd_bread (src, (bfd_size_type) 1, abfd) != 1);
if (is_eof)