mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-03-13 13:49:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

[gdb/testsuite] Fix gdb.base/catch-syscall.exp without --enable-targets

Browse Source 
When doing a gdb build without --enable-targets, I run into:
...
(gdb) UNSUPPORTED: gdb.base/catch-syscall.exp: multiple targets: \
  s390:31-bit vs s390:64-bit: set architecture s390:64-bit
delete breakpoints^M
(gdb) info breakpoints^M
No breakpoints or watchpoints.^M
(gdb) break -qualified main^M
No symbol table is loaded.  Use the "file" command.^M
Make breakpoint pending on future shared library load? (y or [n]) n^M
(gdb) FAIL: gdb.base/catch-syscall.exp: gdb_breakpoint: set breakpoint at main
...

The problem is that due to recent commit e21d8399303 ("[gdb/testsuite] Remove
target limits in gdb.base/catch-syscall.exp") "clean_restart $binfile" no
longer is called at the end of test_catch_syscall_multi_arch.

Fix this by moving "clean_restart $binfile" back to
test_catch_syscall_multi_arch.

Tested on x86_64-linux.
This commit is contained in:
Tom de Vries 2022-05-11 13:30:33 +02:00
parent 4d88ae0c7b
commit b00d6678f6
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/testsuite/gdb.base/catch-syscall.exp
View File

@ -568,7 +568,7 @@ proc test_catch_syscall_with_wrong_args_noxml {} {
proc test_catch_syscall_multi_arch_1 {
arch1 arch2 syscall1_name syscall2_name syscall_number
} {
global decimal binfile
global decimal
with_test_prefix "multiple targets: $arch1 vs $arch2" {
# We are not interested in loading any binary here, and in
@ -605,12 +605,12 @@ proc test_catch_syscall_multi_arch_1 {
gdb_test "catch syscall $syscall_number" \
"Catchpoint $decimal \\(syscall .${syscall2_name}. \\\[${syscall_number}\\\]\\)" \
"insert catch syscall on syscall $syscall_number -- $syscall2_name on $arch2"
clean_restart $binfile
}
}
proc test_catch_syscall_multi_arch {} {
global binfile
set arch1 "i386"
set arch2 "i386:x86-64"
set syscall1_name "exit"
@ -650,6 +650,8 @@ proc test_catch_syscall_multi_arch {} {
set syscall_number 142
test_catch_syscall_multi_arch_1 $arch1 $arch2 $syscall1_name \
$syscall2_name $syscall_number
clean_restart $binfile
}
proc do_syscall_tests_without_xml {} {