Fix a crash with a malformed PE header

Don't try to read the PE export table when no section contains the RVA
for it.

(I have a PE executable [1] packed with UPX, where the export table data
directory entry contains a RVA which doesn't correspond to any section.
Mistakenly trying to debug this with gdb makes it crash.)

[1] https://cygwin.com/setup/setup-2.898.x86_64.exe

gdb/ChangeLog:

2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>

	* coff-pe-read.c (read_pe_exported_syms): Don't try to read the
	export table if no section contains it's RVA.
This commit is contained in:
Jon Turney 2020-01-02 00:25:56 +00:00
parent 89a65580f4
commit a08c904d4e
No known key found for this signature in database
GPG Key ID: C7C86F0370285C81
2 changed files with 11 additions and 0 deletions

View File

@ -1,3 +1,8 @@
2020-01-02 Jon Turney <jon.turney@dronecode.org.uk>
* coff-pe-read.c (read_pe_exported_syms): Don't try to read the
export table if no section contains it's RVA.
2020-01-06 Eli Zaretskii <eliz@gnu.org>
* windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.

View File

@ -441,6 +441,12 @@ read_pe_exported_syms (minimal_symbol_reader &reader,
}
}
if (expptr == 0)
{
/* no section contains export table rva */
return;
}
export_rva = export_opthdrrva;
export_size = export_opthdrsize;