mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-02-17 13:10:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

libctf: Avoid use of uninitialised variables

Browse Source 
* ctf-link.c (ctf_link_add_ctf_internal): Don't free uninitialised
	pointers.
This commit is contained in:
Alan Modra 2022-07-31 22:51:55 +09:30
parent 1a5178fe28
commit 9ea6fffe1e
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
libctf/ctf-link.c
View File

@ -114,7 +114,7 @@ ctf_link_add_ctf_internal (ctf_dict_t *fp, ctf_archive_t *ctf,
goto oom;
if ((input = calloc (1, sizeof (ctf_link_input_t))) == NULL)
goto oom;
goto oom1;
input->clin_arc = ctf;
input->clin_fp = fp_input;
@ -125,19 +125,23 @@ ctf_link_add_ctf_internal (ctf_dict_t *fp, ctf_archive_t *ctf,
{
if (asprintf (&keyname, "%s#%li", name, (long int)
ctf_dynhash_elements (fp->ctf_link_inputs)) < 0)
goto oom;
goto oom2;
}
else if ((keyname = strdup (name)) == NULL)
goto oom;
goto oom2;
if (ctf_dynhash_insert (fp->ctf_link_inputs, keyname, input) < 0)
goto oom;
goto oom3;
return 0;
oom:
free (input);
free (filename);
oom3:
free (keyname);
oom2:
free (input);
oom1:
free (filename);
oom:
return ctf_set_errno (fp, ENOMEM);
}