mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-03 04:12:10 +08:00
PR tdep/17379: Fix internal-error when stack pointer is invalid.
The problem is that rs6000_frame_cache attempts to read the stack backchain via read_memory_unsigned_integer, which throws an exception if the stack pointer is invalid. With this patch, it calls safe_read_memory_integer instead, which doesn't throw an exception and allows for safe handling of that situation. gdb/ChangeLog 2014-09-12 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com> Ulrich Weigand <uweigand@de.ibm.com> PR tdep/17379 * rs6000-tdep.c (rs6000_frame_cache): Use safe_read_memory_integer instead of read_memory_unsigned_integer. gdb/testcase/ChangeLog 2014-09-12 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com> PR tdep/17379 * gdb.arch/powerpc-stackless.S: New file. * gdb.arch/powerpc-stackless.exp: New file.
This commit is contained in:
parent
1cf2f1b045
commit
9d9bf2df89
@ -1,3 +1,10 @@
|
||||
2014-09-12 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
|
||||
Ulrich Weigand <uweigand@de.ibm.com>
|
||||
|
||||
PR tdep/17379
|
||||
* rs6000-tdep.c (rs6000_frame_cache): Use safe_read_memory_integer
|
||||
instead of read_memory_unsigned_integer.
|
||||
|
||||
2014-09-12 Gary Benson <gbenson@redhat.com>
|
||||
|
||||
* nat/linux-waitpid.c: Include common-defs.h.
|
||||
|
@ -3190,9 +3190,14 @@ rs6000_frame_cache (struct frame_info *this_frame, void **this_cache)
|
||||
}
|
||||
|
||||
if (!fdata.frameless)
|
||||
/* Frameless really means stackless. */
|
||||
cache->base
|
||||
= read_memory_unsigned_integer (cache->base, wordsize, byte_order);
|
||||
{
|
||||
/* Frameless really means stackless. */
|
||||
LONGEST backchain;
|
||||
|
||||
if (safe_read_memory_integer (cache->base, wordsize,
|
||||
byte_order, &backchain))
|
||||
cache->base = (CORE_ADDR) backchain;
|
||||
}
|
||||
|
||||
trad_frame_set_value (cache->saved_regs,
|
||||
gdbarch_sp_regnum (gdbarch), cache->base);
|
||||
|
@ -1,3 +1,9 @@
|
||||
2014-09-12 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
|
||||
|
||||
PR tdep/17379
|
||||
* gdb.arch/powerpc-stackless.S: New file.
|
||||
* gdb.arch/powerpc-stackless.exp: New file.
|
||||
|
||||
2014-09-12 Jan Kratochvil <jan.kratochvil@redhat.com>
|
||||
|
||||
* gdb.base/attach.c: Include unistd.h.
|
||||
|
24
gdb/testsuite/gdb.arch/powerpc-stackless.S
Normal file
24
gdb/testsuite/gdb.arch/powerpc-stackless.S
Normal file
@ -0,0 +1,24 @@
|
||||
/* This testcase is part of GDB, the GNU debugger.
|
||||
|
||||
Copyright 2014 Free Software Foundation, Inc.
|
||||
|
||||
This program is free software; you can redistribute it and/or modify
|
||||
it under the terms of the GNU General Public License as published by
|
||||
the Free Software Foundation; either version 3 of the License, or
|
||||
(at your option) any later version.
|
||||
|
||||
This program is distributed in the hope that it will be useful,
|
||||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
GNU General Public License for more details.
|
||||
|
||||
You should have received a copy of the GNU General Public License
|
||||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||||
|
||||
#include <ppc-asm.h>
|
||||
|
||||
FUNC_START(main)
|
||||
li sp,0
|
||||
mtlr sp
|
||||
blr
|
||||
FUNC_END(main)
|
42
gdb/testsuite/gdb.arch/powerpc-stackless.exp
Normal file
42
gdb/testsuite/gdb.arch/powerpc-stackless.exp
Normal file
@ -0,0 +1,42 @@
|
||||
# Copyright 2014 Free Software Foundation, Inc.
|
||||
|
||||
# This program is free software; you can redistribute it and/or modify
|
||||
# it under the terms of the GNU General Public License as published by
|
||||
# the Free Software Foundation; either version 2 of the License, or
|
||||
# (at your option) any later version.
|
||||
#
|
||||
# This program is distributed in the hope that it will be useful,
|
||||
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
# GNU General Public License for more details.
|
||||
#
|
||||
# You should have received a copy of the GNU General Public License
|
||||
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
|
||||
# Testcase for PR tdep/17379.
|
||||
|
||||
if {![istarget "powerpc*-*-*"]} then {
|
||||
verbose "Skipping powerpc-stackless.exp"
|
||||
return
|
||||
}
|
||||
|
||||
standard_testfile .S
|
||||
|
||||
if { [prepare_for_testing $testfile.exp $testfile $srcfile] } {
|
||||
untested powerpc-stackless.exp
|
||||
return -1
|
||||
}
|
||||
|
||||
# Run until SIGSEGV.
|
||||
gdb_run_cmd
|
||||
|
||||
set test "run until SIGSEGV"
|
||||
gdb_test_multiple "" $test {
|
||||
-re "Program received signal SIGSEGV.*$gdb_prompt $" {
|
||||
pass $test
|
||||
}
|
||||
}
|
||||
|
||||
# Ensure that 'info registers' works properly and does not generate
|
||||
# an internal-error.
|
||||
gdb_test "info registers" "r0.*" "info registers"
|
Loading…
Reference in New Issue
Block a user