mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-01-18 12:24:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

LD/testsuite: Conditionalize the placement of `.dynamic' in GNU_RELRO

Browse Source 
Complement commit d345186d05 ("Check if GNU_RELRO segment is is
generated") and exclude the presence of a `.dynamic' section from
implying the creation of a GNU_RELRO segment for targets which place the
section in the (read-only) text segment, and therefore cannot have the
section assigned to GNU_RELRO and neither it would make sense.

Currently the list of such targets consists of 64-bit HPPA and
non-VxWorks MIPS targets, as determined by looking for TEXT_DYNAMIC
being set across ld/emulparams/* and then verified by examining default
linker scripts produced in a `--enable-targets=all' build.

	ld/
	* testsuite/ld-elf/binutils.exp (binutils_test): Make the
	expectation for `.dynamic' in GNU_RELRO segment target-specific.
This commit is contained in:
Maciej W. Rozycki 2017-07-18 17:20:30 +01:00
parent de194d8575
commit 9a0f1d5099
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ld/ChangeLog
View File

@ -1,3 +1,8 @@
2017-07-18 Maciej W. Rozycki <macro@imgtec.com>
* testsuite/ld-elf/binutils.exp (binutils_test): Make the
expectation for `.dynamic' in GNU_RELRO segment target-specific.
2017-07-18 Nick Clifton <nickc@redhat.com>
PR 21775

7
ld/testsuite/ld-elf/binutils.exp
View File

@ -81,12 +81,17 @@ proc binutils_test { prog_name ld_options test {test_name ""} {readelf_options "
}
if [string match "*-z relro*" $ld_options] {
# These targets set TEXT_DYNAMIC and therefore have `.dynamic'
# in the (read-only) text segment rather than data segment.
set relro_dynamic [expr !([istarget "hppa64*-*-*"] \
|| ([istarget "mips*-*-*"] \
&& ![istarget "*-*-vxworks*"]))]
# Check if GNU_RELRO segment is generated.
set got [remote_exec host "grep GNU_RELRO tmpdir/$test.exp"]
if { ![string match "*GNU_RELRO*" $got] } then {
set got [remote_exec host "cat tmpdir/$test.exp"]
if { [string match "*.data.rel.ro*" $got]
|| [string match "*.dynamic*" $got]
|| ($relro_dynamic && [string match "*.dynamic*" $got])
|| [string match "*.got*" $got]
|| [string match "*.eh_frame*" $got]
|| [string match "*.gcc_except_table*" $got]