mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-27 03:51:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use htab_up in filename_seen_cache

Browse Source 
This changes filename_seen_cache to use htab_up, rather than explicit
calls to htab_delete.

gdb/ChangeLog
2020-09-17  Tom Tromey  <tom@tromey.com>

	* filename-seen-cache.c (filename_seen_cache::filename_seen_cache)
	(filename_seen_cache::clear): Update.
	(~filename_seen_cache): Remove.
	(filename_seen_cache::seen): Update.
	* filename-seen-cache.h (class filename_seen_cache) <m_tab>: Now
	htab_up.
	<~filename_seen_cache>: Remove.
	<traverse>: Update.
This commit is contained in:
Tom Tromey 2020-09-17 11:47:50 -06:00
parent 32580f6d2e
commit 99032cfcc6
3 changed files with 18 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
gdb/ChangeLog
View File

@ -1,3 +1,14 @@
2020-09-17 Tom Tromey <tom@tromey.com>
* filename-seen-cache.c (filename_seen_cache::filename_seen_cache)
(filename_seen_cache::clear): Update.
(~filename_seen_cache): Remove.
(filename_seen_cache::seen): Update.
* filename-seen-cache.h (class filename_seen_cache) <m_tab>: Now
htab_up.
<~filename_seen_cache>: Remove.
<traverse>: Update.
2020-09-17 Tom Tromey <tom@tromey.com>
* completer.c (completion_tracker::discard_completions)

17
gdb/filename-seen-cache.c
View File

@ -27,10 +27,10 @@
/* filename_seen_cache constructor. */
filename_seen_cache::filename_seen_cache ()
: m_tab (htab_create_alloc (INITIAL_FILENAME_SEEN_CACHE_SIZE,
filename_hash, filename_eq,
NULL, xcalloc, xfree))
{
m_tab = htab_create_alloc (INITIAL_FILENAME_SEEN_CACHE_SIZE,
filename_hash, filename_eq,
NULL, xcalloc, xfree);
}
/* See filename-seen-cache.h. */
@ -38,14 +38,7 @@ filename_seen_cache::filename_seen_cache ()
void
filename_seen_cache::clear ()
{
htab_empty (m_tab);
}
/* See filename-seen-cache.h. */
filename_seen_cache::~filename_seen_cache ()
{
htab_delete (m_tab);
htab_empty (m_tab.get ());
}
/* See filename-seen-cache.h. */
@ -56,7 +49,7 @@ filename_seen_cache::seen (const char *file)
void **slot;
/* Is FILE in tab? */
slot = htab_find_slot (m_tab, file, INSERT);
slot = htab_find_slot (m_tab.get (), file, INSERT);
if (*slot != NULL)
return true;

5
gdb/filename-seen-cache.h
View File

@ -29,7 +29,6 @@ class filename_seen_cache
{
public:
filename_seen_cache ();
~filename_seen_cache ();
DISABLE_COPY_AND_ASSIGN (filename_seen_cache);
@ -55,12 +54,12 @@ class filename_seen_cache
return 1;
};
htab_traverse_noresize (m_tab, erased_cb, &callback);
htab_traverse_noresize (m_tab.get (), erased_cb, &callback);
}
private:
/* Table of files seen so far. */
htab_t m_tab;
htab_up m_tab;
};
#endif /* FILENAME_SEEN_CACHE_H */