mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-12-15 04:31:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdb: add type::is_flag_enum / type::set_is_flag_enum

Browse Source 
Add the `is_flag_enum` and `set_is_flag_enum` methods on `struct type`,
in order to remove the `TYPE_FLAG_ENUM` macro.  In this patch, the macro
is changed to use the getter, so all the call sites of the macro that
are used as a setter are changed to use the setter method directly.  The
next patch will remove the macro completely.

gdb/ChangeLog:

	* gdbtypes.h (struct type) <is_flag_enum,
	set_is_flag_enum>: New methods.
	(TYPE_FLAG_ENUM): Use type::is_flag_enum, change all
	write call sites to use type::set_is_flag_enum.

Change-Id: I9c56c91626c8d784947ba94fcb97818526b81d1c
This commit is contained in:
Simon Marchi 2021-04-01 21:10:09 -04:00 committed by Simon Marchi
parent 3bc440a2c4
commit 9902b32793
3 changed files with 24 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@ -1,3 +1,10 @@
2021-04-01 Simon Marchi <simon.marchi@efficios.com>
* gdbtypes.h (struct type) <is_flag_enum,
set_is_flag_enum>: New methods.
(TYPE_FLAG_ENUM): Use type::is_flag_enum, change all
write call sites to use type::set_is_flag_enum.
2021-04-01 Simon Marchi <simon.marchi@efficios.com>
* gdbtypes.h (TYPE_DECLARED_CLASS): Remove, replace all uses

2
gdb/dwarf2/read.c
View File

@ -16677,7 +16677,7 @@ update_enumeration_type_from_children (struct die_info *die,
type->set_is_unsigned (true);
if (flag_enum)
TYPE_FLAG_ENUM (type) = 1;
type->set_is_flag_enum (true);
}
/* Given a DW_AT_enumeration_type die, set its type. We do not

22
gdb/gdbtypes.h
View File

@ -220,11 +220,7 @@ DEF_ENUM_FLAGS_TYPE (enum type_instance_flag_value, type_instance_flags);
#define TYPE_NOTTEXT(t) (((t)->instance_flags ()) & TYPE_INSTANCE_FLAG_NOTTEXT)
/* * True if this type is a "flag" enum. A flag enum is one where all
the values are pairwise disjoint when "and"ed together. This
affects how enum values are printed. */
#define TYPE_FLAG_ENUM(t) (TYPE_MAIN_TYPE (t)->flag_flag_enum)
#define TYPE_FLAG_ENUM(t) ((t)->is_flag_enum ())
/* * Constant type. If this is set, the corresponding type has a
const modifier. */
@ -812,7 +808,7 @@ struct main_type
/* * True if this is an enum type with disjoint values. This
affects how the enum is printed. */
unsigned int flag_flag_enum : 1;
unsigned int m_flag_flag_enum : 1;
/* * A discriminant telling us which field of the type_specific
union is being used for this type, if any. */
@ -1196,6 +1192,20 @@ struct type
this->main_type->m_flag_declared_class = is_declared_class;
}
/* True if this type is a "flag" enum. A flag enum is one where all
the values are pairwise disjoint when "and"ed together. This
affects how enum values are printed. */
bool is_flag_enum () const
{
return this->main_type->m_flag_flag_enum;
}
void set_is_flag_enum (bool is_flag_enum)
{
this->main_type->m_flag_flag_enum = is_flag_enum;
}
/* * Assuming that THIS is a TYPE_CODE_FIXED_POINT, return a reference
to this type's fixed_point_info. */