mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-27 03:51:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

PR32032 dwp segfaults on hello world binary

Browse Source 
Fixing the segfault is easy with this bandaid, but further work is
needed to teach dwp about DW_AT_dwo_name and dwo id in the cu header.
At the moment dwp only handles DW_AT_GNU_dwo_name and DW_AT_GNU_dwo_id.

	PR 32032
	* dwp.cc (Dwp_output_file::finalize): Return immediately on
	no output file.
This commit is contained in:
Alan Modra 2024-07-29 14:25:07 +09:30
parent 2509e28c88
commit 972092a9ed
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gold/dwp.cc
View File

@ -1838,6 +1838,9 @@ Dwp_output_file::finalize()
{
unsigned char* buf;
if (this->fd_ == NULL)
return;
// Write the accumulated output sections.
for (unsigned int i = 0; i < this->sections_.size(); i++)
{
@ -1919,11 +1922,8 @@ Dwp_output_file::finalize()
this->write_ehdr();
// Close the file.
if (this->fd_ != NULL)
{
if (::fclose(this->fd_) != 0)
gold_fatal(_("%s: %s"), this->name_, strerror(errno));
}
if (::fclose(this->fd_) != 0)
gold_fatal(_("%s: %s"), this->name_, strerror(errno));
this->fd_ = NULL;
}