mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-03-01 13:26:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

Replace 0 with TARGET_XFER_EOF in to_xfer_partial

Browse Source 
I run splint in gdb source and get the following warnings:

  ../../../git/gdb/corelow.c:740: Return value type int does not match declared type enum target_xfer_status: 0

'TARGET_XFER_EOF' (enum target_xfer_status) is expected to be returned,
but 0 is returned.  This patch is to replace 0 with TARGET_XFER_EOF
in the implementations of to_xfer_partial.

gdb:

2014-08-07  Yao Qi  <yao@codesourcery.com>

	* corelow.c (core_xfer_partial): Replace 0 with TARGET_XFER_EOF.
	* remote-m32r-sdi.c (m32r_xfer_memory): Likewise.
	* remote.c (remote_read_bytes): Likewise.
This commit is contained in:
Yao Qi 2014-08-06 14:02:35 +08:00
parent fffbe6a8c8
commit 96c4f946a8
4 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2014-08-07 Yao Qi <yao@codesourcery.com>
* corelow.c (core_xfer_partial): Replace 0 with TARGET_XFER_EOF.
* remote-m32r-sdi.c (m32r_xfer_memory): Likewise.
* remote.c (remote_read_bytes): Likewise.
2014-08-07 Yao Qi <yao@codesourcery.com>
* dwarf2read.c (struct dwarf2_per_cu_data) <u>: Tweak comments.

2
gdb/corelow.c
View File

@ -734,7 +734,7 @@ core_xfer_partial (struct target_ops *ops, enum target_object object,
size = bfd_section_size (core_bfd, section);
if (offset >= size)
return 0;
return TARGET_XFER_EOF;
size -= offset;
if (size > len)
size = len;

6
gdb/remote-m32r-sdi.c
View File

@ -1080,7 +1080,7 @@ m32r_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf,
if (remote_debug)
fprintf_unfiltered (gdb_stdlog,
"m32r_xfer_memory() failed\n");
return 0;
return TARGET_XFER_EOF;
}
ret = send_data (writebuf, len);
}
@ -1094,7 +1094,7 @@ m32r_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf,
{
if (remote_debug)
fprintf_unfiltered (gdb_stdlog, "m32r_xfer_memory() failed\n");
return 0;
return TARGET_XFER_EOF;
}
c = serial_readchar (sdi_desc, SDI_TIMEOUT);
@ -1102,7 +1102,7 @@ m32r_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf,
{
if (remote_debug)
fprintf_unfiltered (gdb_stdlog, "m32r_xfer_memory() failed\n");
return 0;
return TARGET_XFER_EOF;
}
ret = recv_data (readbuf, len);

2
gdb/remote.c
View File

@ -6823,7 +6823,7 @@ remote_read_bytes (struct target_ops *ops, CORE_ADDR memaddr,
gdb_byte *myaddr, ULONGEST len, ULONGEST *xfered_len)
{
if (len == 0)
return 0;
return TARGET_XFER_EOF;
if (get_traceframe_number () != -1)
{