bfd: fix -std=gnu23 compatibility wrt _Bool

GCC trunk now defaults to -std=gnu23. We return false in a few places
which can't work when true/false are a proper type (_Bool). Return NULL
where appropriate instead of false. All callers handle this appropriately.

ChangeLog:
	PR ld/32372

	* elf32-ppc.c (ppc_elf_tls_setup): Return NULL.
        * elf32-xtensa.c (translate_reloc_bfd_fix): Ditto.
        (translate_reloc): Ditto.
        * elf64-ppc.c (update_local_sym_info): Ditto.
        * mach-o.c (bfd_mach_o_lookup_uuid_command): Ditto.
        * xsym.c (bfd_sym_read_name_table): Ditto.
This commit is contained in:
Sam James 2024-11-16 05:01:58 +00:00
parent 5b61986ac1
commit 931e4f9b09
No known key found for this signature in database
GPG Key ID: 738409F520DF9190
5 changed files with 6 additions and 6 deletions

View File

@ -4352,7 +4352,7 @@ ppc_elf_tls_setup (bfd *obfd, struct bfd_link_info *info)
_bfd_elf_strtab_delref (elf_hash_table (info)->dynstr,
opt->dynstr_index);
if (!bfd_elf_link_record_dynamic_symbol (info, opt))
return false;
return NULL;
}
htab->tls_get_addr = opt;
}

View File

@ -10070,7 +10070,7 @@ translate_reloc_bfd_fix (reloc_bfd_fix *fix)
location. Otherwise, the relocation should move within the
section. */
removed = false;
removed = NULL;
if (is_operand_relocation (fix->src_type))
{
/* Check if the original relocation is against a literal being
@ -10141,7 +10141,7 @@ translate_reloc (const r_reloc *orig_rel, r_reloc *new_rel, asection *sec)
target_offset = orig_rel->target_offset;
removed = false;
removed = NULL;
if (is_operand_relocation (ELF32_R_TYPE (orig_rel->rela.r_info)))
{
/* Check if the original relocation is against a literal being

View File

@ -4664,7 +4664,7 @@ update_local_sym_info (bfd *abfd, Elf_Internal_Shdr *symtab_hdr,
size_t amt = sizeof (*ent);
ent = bfd_alloc (abfd, amt);
if (ent == NULL)
return false;
return NULL;
ent->next = local_got_ents[r_symndx];
ent->addend = r_addend;
ent->owner = abfd;

View File

@ -6037,7 +6037,7 @@ bfd_mach_o_lookup_uuid_command (bfd *abfd)
bfd_mach_o_load_command *uuid_cmd = NULL;
int ncmd = bfd_mach_o_lookup_command (abfd, BFD_MACH_O_LC_UUID, &uuid_cmd);
if (ncmd != 1 || uuid_cmd == NULL)
return false;
return NULL;
return &uuid_cmd->command.uuid;
}

View File

@ -130,7 +130,7 @@ bfd_sym_read_name_table (bfd *abfd, bfd_sym_header_block *dshb)
size_t table_offset = dshb->dshb_nte.dti_first_page * dshb->dshb_page_size;
if (bfd_seek (abfd, table_offset, SEEK_SET) != 0)
return false;
return NULL;
return _bfd_alloc_and_read (abfd, table_size, table_size);
}