2
0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-01-06 12:09:26 +08:00

[gdb/testsuite] Fix FAILs due to PR gcc/101452

When running test-case gdb.base/ptype-offsets.exp with gcc-11 (with -gdwarf-5
default) or gcc-10 with target board unix/gdb:debug_flags=-gdwarf-5 we run
into this regression:
...
 (gdb) ptype/o static_member^M
 /* offset      |    size */  type = struct static_member {^M
-                               static static_member Empty;^M
 /*      0      |       4 */    int abc;^M
 ^M
                                /* total size (bytes):    4 */^M
                              }^M
-(gdb) PASS: gdb.base/ptype-offsets.exp: ptype/o static_member
+(gdb) FAIL: gdb.base/ptype-offsets.exp: ptype/o static_member
...

This is caused by missing debug info, which I filed as gcc PR101452 - "[debug,
dwarf-5] undefined static member removed by
-feliminate-unused-debug-symbols".

It's not clear yet whether this is a bug or a feature, but work around this in
the test-cases by:
- defining the static member
- adding additional_flags=-fno-eliminate-unused-debug-types.

Tested on x86_64-linux.

gdb/testsuite/ChangeLog:

2021-07-20  Tom de Vries  <tdevries@suse.de>

	* lib/gdb.exp (gcc_major_version): New proc.
	* gdb.base/ptype-offsets.cc: Define static member static_member::Empty.
	* gdb.cp/templates.exp: Define static member using -DGCC_BUG.
	* gdb.cp/m-static.exp: Add
	additional_flags=-fno-eliminate-unused-debug-types.
	* gdb.cp/pr-574.exp: Same.
	* gdb.cp/pr9167.exp: Same.
This commit is contained in:
Tom de Vries 2021-07-21 14:19:51 +02:00
parent 0057a7ee0d
commit 8f5d31b8d1
6 changed files with 52 additions and 4 deletions

View File

@ -185,6 +185,9 @@ struct static_member
int abc;
};
/* Work around PR gcc/101452. */
static_member static_member::Empty;
struct empty_member
{
struct { } empty;

View File

@ -31,8 +31,14 @@ if [get_compiler_info] {
return -1
}
set flags [list debug c++]
if { [test_compiler_info gcc-*] && [gcc_major_version] >= 10 } {
# Work around PR gcc/101452.
lappend flags additional_flags=-fno-eliminate-unused-debug-types
}
if {[prepare_for_testing "failed to prepare" $testfile \
[list $srcfile $srcfile2] {debug c++}]} {
[list $srcfile $srcfile2] $flags]} {
return -1
}

View File

@ -32,7 +32,13 @@ if [get_compiler_info "c++"] {
return -1
}
if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} {
set flags [list debug c++]
if { [test_compiler_info gcc-*] && [gcc_major_version] >= 10 } {
# Work around PR gcc/101452.
lappend flags additional_flags=-fno-eliminate-unused-debug-types
}
if {[prepare_for_testing "failed to prepare" $testfile $srcfile $flags]} {
return -1
}

View File

@ -15,7 +15,13 @@
standard_testfile .cc
if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} {
set flags [list debug c++]
if { [test_compiler_info gcc-*] && [gcc_major_version] >= 10 } {
# Work around PR gcc/101452.
lappend flags additional_flags=-fno-eliminate-unused-debug-types
}
if {[prepare_for_testing "failed to prepare" $testfile $srcfile $flags]} {
return -1
}

View File

@ -27,7 +27,13 @@ if [get_compiler_info "c++"] {
return -1
}
if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} {
set flags [list debug c++]
if { [test_compiler_info gcc-*] && [gcc_major_version] >= 10 } {
# Work around PR gcc/101452.
lappend flags additional_flags=-DGCC_BUG
}
if {[prepare_for_testing "failed to prepare" $testfile $srcfile $flags]} {
return -1
}

View File

@ -3998,6 +3998,27 @@ proc test_compiler_info { {compiler ""} } {
return [string match $compiler $compiler_info]
}
# Return the gcc major version, or -1.
# For gcc 4.8.5, the major version is 4.8.
# For gcc 7.5.0, the major version 7.
proc gcc_major_version { } {
global compiler_info
global decimal
if { ![test_compiler_info "gcc-*"] } {
return -1
}
set res [regexp gcc-($decimal)-($decimal)- $compiler_info \
dummy_var major minor]
if { $res != 1 } {
return -1
}
if { $major >= 5} {
return $major
}
return $major.$minor
}
proc current_target_name { } {
global target_info
if [info exists target_info(target,name)] {