mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-03-01 13:26:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments for the previous series

Browse Source 
I failed at git and missed adding/lost changes on the wrong branch, the
result being that I didn't incorporate fixes resulting from Yao's review
comments.  This patch fixes that.

There are two places where we should use the unique pointer typedef, and
ChangeLog entries missing.

gdb/ChangeLog:

	* target-descriptions.c (struct tdesc_feature) <registers>: Use
	tdesc_reg_up typedef.
	(struct target_desc) <features>: Use tdesc_feature_up typedef.
This commit is contained in:
Simon Marchi 2017-12-05 16:39:35 -05:00
parent d4a0e8b57d
commit 858c9d1324
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2017-12-05 Simon Marchi <simon.marchi@ericsson.com>
* target-descriptions.c (struct tdesc_feature) <registers>: Use
tdesc_reg_up typedef.
(struct target_desc) <features>: Use tdesc_feature_up typedef.
2017-12-05 Simon Marchi <simon.marchi@polymtl.ca>
* target-descriptions.c (struct tdesc_type): Use default
@ -118,6 +124,8 @@
(tdesc_register_in_reggroup_p): Adjust.
(class print_c_tdesc) <visit>: Adjust.
(class print_c_feature) <visit>: Adjust.
* features/arc-arcompact.c: Re-generate.
* features/arc-v2.c: Re-generate.
2017-12-05 Simon Marchi <simon.marchi@ericsson.com>

4
gdb/target-descriptions.c
View File

@ -529,7 +529,7 @@ struct tdesc_feature : tdesc_element
std::string name;
/* The registers associated with this feature. */
std::vector<std::unique_ptr<tdesc_reg>> registers;
std::vector<tdesc_reg_up> registers;
/* The types associated with this feature. */
std::vector<tdesc_type_up> types;
@ -613,7 +613,7 @@ struct target_desc : tdesc_element
std::vector<property> properties;
/* The features associated with this target. */
std::vector<std::unique_ptr<tdesc_feature>> features;
std::vector<tdesc_feature_up> features;
void accept (tdesc_element_visitor &v) const override
{