mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-02-17 13:10:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

elf: Correct DT_TEXTREL warning in PDE

Browse Source 
Change

ld: warning: creating DT_TEXTREL in a PIE

to

ld: warning: creating DT_TEXTREL in a PDE

on PDE.

bfd/

	* elflink.c (bfd_elf_final_link): Correct DT_TEXTREL warning in
	PDE.

ld/

	* testsuite/ld-x86-64/textrel-1.err: New file.
	* testsuite/ld-x86-64/textrel-1a.s: Likewise.
	* testsuite/ld-x86-64/textrel-1b.s: Likewise.
	* testsuite/ld-x86-64/x86-64.exp: Run textrel-1 tests.
This commit is contained in:
H.J. Lu 2021-06-19 16:33:24 -07:00
parent ce3ec98acd
commit 83b1d8f4a6
7 changed files with 48 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bfd/ChangeLog
View File

@ -1,3 +1,8 @@
2021-06-19 H.J. Lu <hongjiu.lu@intel.com>
* elflink.c (bfd_elf_final_link): Correct DT_TEXTREL warning in
PDE.
2021-06-18 H.J. Lu <hongjiu.lu@intel.com>
* elf-properties.c (_bfd_elf_parse_gnu_properties): Handle

3
bfd/elflink.c
View File

@ -13138,6 +13138,9 @@ bfd_elf_final_link (bfd *abfd, struct bfd_link_info *info)
else if (bfd_link_dll (info))
info->callbacks->einfo
(_("%P: warning: creating DT_TEXTREL in a shared object\n"));
else if (bfd_link_pde (info))
info->callbacks->einfo
(_("%P: warning: creating DT_TEXTREL in a PDE\n"));
else
info->callbacks->einfo
(_("%P: warning: creating DT_TEXTREL in a PIE\n"));

7
ld/ChangeLog
View File

@ -1,3 +1,10 @@
2021-06-19 H.J. Lu <hongjiu.lu@intel.com>
* testsuite/ld-x86-64/textrel-1.err: New file.
* testsuite/ld-x86-64/textrel-1a.s: Likewise.
* testsuite/ld-x86-64/textrel-1b.s: Likewise.
* testsuite/ld-x86-64/x86-64.exp: Run textrel-1 tests.
2021-06-18 H.J. Lu <hongjiu.lu@intel.com>
* testsuite/ld-elf/property-and-1.d: Skip am33_2.0, hppa-hpux

4
ld/testsuite/ld-x86-64/textrel-1.err Normal file
View File

@ -0,0 +1,4 @@
#...
.*textrel-1b.o: warning: relocation against `foo' in read-only section `.rodata'
.*: warning: creating DT_TEXTREL in a PDE
#...

9
ld/testsuite/ld-x86-64/textrel-1a.s Normal file
View File

@ -0,0 +1,9 @@
.text
.globl foo
.data
.align 4
.type foo, @object
.size foo, 4
foo:
.long 4
.section .note.GNU-stack,"",@progbits

15
ld/testsuite/ld-x86-64/textrel-1b.s Normal file
View File

@ -0,0 +1,15 @@
.text
.p2align 4
.globl _start
.type _start, @function
_start:
ret
.size _start, .-_start
.globl ptr
.section .rodata
.align 8
.type ptr, @object
.size ptr, 8
ptr:
.quad foo
.section .note.GNU-stack,"",@progbits

5
ld/testsuite/ld-x86-64/x86-64.exp
View File

@ -231,6 +231,11 @@ set x86_64tests {
"" ""
{ pr27590a.obj.bz2 pr27590b.obj.bz2 }
{{readelf -SW pr27590.rd}} "pr27590.o"}
{"Build textrel-1.so" "-melf_x86_64 -shared" ""
"--64" { textrel-1a.s } {} "textrel-1.so"}
{"Build textrel-1" "-no-pie -melf_x86_64 -z nocopyreloc"
"tmpdir/textrel-1.so"
"--64" { textrel-1b.s } {{ld "textrel-1.err"}} "textrel-1"}
}
run_ld_link_tests $x86_64tests