mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-01-24 12:35:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't supply DAP 'path' for non-file shared libraries

Browse Source 
The DAP 'module' event may include a 'path' component.  I noticed that
this is supplied even when the module in question does not come from a
file.

This patch only emits this field when the objfile corresponds to a
real file.

No test case, because I wasn't sure how to write a portable one.
However, it's clear from gdb.log on Linux:

{"type": "event", "event": "module", "body": {"reason": "new", "module": {"id": "system-supplied DSO at 0x7ffff7fc4000", "name": "system-supplied DSO at 0x7ffff7fc4000"}}, "seq": 21}

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30676
This commit is contained in:
Tom Tromey 2023-07-25 10:55:14 -06:00
parent e137699884
commit 7b4a5561e4
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/python/lib/gdb/dap/modules.py
View File

@ -36,11 +36,13 @@ def make_module(objf):
"""Return a Module representing the objfile OBJF.
The objfile must pass the 'is_module' test."""
return {
result = {
"id": module_id(objf),
"name": objf.username,
"path": objf.filename,
}
if objf.is_file:
result["path"] = objf.filename
return result
@in_gdb_thread