mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-02-11 13:02:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

libctf: fix assertion failure with no system qsort_r

Browse Source 
If no suitable qsort_r is found in libc, we fall back to an
implementation in ctf-qsort.c.  But this implementation routinely calls
the comparison function with two identical arguments. The comparison
function that ensures that the order of output types is stable is not
ready for this, misinterprets it as a type appearing more that once (a
can-never-happen condition) and fails with an assertion failure.

Fixed, audited for further instances of the same failure (none found)
and added a no-qsort test to my regular testsuite run.

libctf/:
	PR libctf/30013
	* ctf-dedup.c (sort_output_mapping): Inputs are always equal to
	themselves.
This commit is contained in:
Nick Alcock 2023-01-23 13:11:32 +00:00
parent 9d7879951a
commit 7aa47eafcc
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libctf/ctf-dedup.c
View File

@ -2306,6 +2306,10 @@ sort_output_mapping (const ctf_next_hkv_t *one, const ctf_next_hkv_t *two,
ctf_id_t one_type;
ctf_id_t two_type;
/* Inputs are always equal to themselves. */
if (one == two)
return 0;
one_gid = ctf_dynhash_lookup (d->cd_output_first_gid, one_hval);
two_gid = ctf_dynhash_lookup (d->cd_output_first_gid, two_hval);