From 6e8c24fe27098f407000812e61fa8210095a7970 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Sat, 23 Dec 2017 16:25:06 -0500 Subject: [PATCH] Add ATTRIBUTE_PRINTF to printf_field_type_assignment Get rid of: /home/simark/src/binutils-gdb/gdb/target-descriptions.c:2026:25: error: format string is not a string literal [-Werror,-Wformat-nonliteral] vprintf_unfiltered (fmt, args); when building with clang. gdb/ChangeLog: * target-descriptions.c (print_c_tdesc) : Add ATTRIBUTE_PRINTF. --- gdb/ChangeLog | 5 +++++ gdb/target-descriptions.c | 1 + 2 files changed, 6 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 1b4b13aba96..c81c611e9a8 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-12-23 Simon Marchi + + * target-descriptions.c (print_c_tdesc) + : Add ATTRIBUTE_PRINTF. + 2017-12-21 Simon Marchi Sergio Durigan Junior diff --git a/gdb/target-descriptions.c b/gdb/target-descriptions.c index 5dcc4c4c5c0..b37f4f0c193 100644 --- a/gdb/target-descriptions.c +++ b/gdb/target-descriptions.c @@ -2011,6 +2011,7 @@ class print_c_tdesc : public tdesc_element_visitor /* Print an assignment to the field_type variable. Print the declaration of field_type if that has not been done yet. */ + ATTRIBUTE_PRINTF (2, 3) void printf_field_type_assignment (const char *fmt, ...) { if (!m_printed_field_type)