mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-02-23 13:21:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix malloc allocation size sanity check

Browse Source 
During debugging of PR26362, it was noticed that the malloc size check
in check_type_length_before_alloc wasn't detecting an allocation attempt
of a huge amount of bytes, making GDB run into an internal error.

This happens because we're using an int to store a type's length. When the
type length is large enough, the int will overflow and the max_value_size
check won't work anymore.

The following patch fixes this by making the length variable a ULONGEST.

Printing statements were also updated to show the correct number of bytes.

gdb/ChangeLog:

2020-08-12  Luis Machado  <luis.machado@linaro.org>

	* value.c (check_type_length_before_alloc): Use ULONGEST to store a
	type's length.
	Use %s and pulongest to print the length.
This commit is contained in:
Luis Machado 2020-08-12 17:02:32 -03:00
parent 7cf663a932
commit 6d8a0a5e90
2 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2020-08-12 Luis Machado <luis.machado@linaro.org>
* value.c (check_type_length_before_alloc): Use ULONGEST to store a
type's length.
Use %s and pulongest to print the length.
2020-08-12 Pedro Alves <palves@redhat.com>
* NEWS: Move "Multi-target debugging support" item to the

10
gdb/value.c
View File

@ -997,16 +997,16 @@ show_max_value_size (struct ui_file *file, int from_tty,
static void
check_type_length_before_alloc (const struct type *type)
{
unsigned int length = TYPE_LENGTH (type);
ULONGEST length = TYPE_LENGTH (type);
if (max_value_size > -1 && length > max_value_size)
{
if (type->name () != NULL)
error (_("value of type `%s' requires %u bytes, which is more "
"than max-value-size"), type->name (), length);
error (_("value of type `%s' requires %s bytes, which is more "
"than max-value-size"), type->name (), pulongest (length));
else
error (_("value requires %u bytes, which is more than "
"max-value-size"), length);
error (_("value requires %s bytes, which is more than "
"max-value-size"), pulongest (length));
}
}