From 6b3661116e7b01676299710a96f47fe06bafacec Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 13 Jan 2020 14:03:04 -0500 Subject: [PATCH] gdb: add declaration to Python init function MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When I try to enable -Wmissing-declarations, I get this error: CXX python/python.o /home/smarchi/src/binutils-gdb/gdb/python/python.c: In function ‘PyObject* init__gdb_module()’: /home/smarchi/src/binutils-gdb/gdb/python/python.c:1582:1: error: no previous declaration for ‘PyObject* init__gdb_module()’ [-Werror=missing-declarations] init__gdb_module (void) ^~~~~~~~~~~~~~~~ Prevent it by providing a declaration just before the definition. gdb/ChangeLog: * python/python.c (init__gdb_module): Add declaration. Change-Id: I394bc691b7db624708cc4cb2cda28a56ab85a82b --- gdb/ChangeLog | 4 ++++ gdb/python/python.c | 1 + 2 files changed, 5 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a9db32253da..f2992f17844 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2020-01-13 Simon Marchi + + * python/python.c (init__gdb_module): Add declaration. + 2020-01-13 Simon Marchi * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration. diff --git a/gdb/python/python.c b/gdb/python/python.c index f7aadb1633c..e0c05f1d068 100644 --- a/gdb/python/python.c +++ b/gdb/python/python.c @@ -1555,6 +1555,7 @@ finalize_python (void *ignore) /* This is called via the PyImport_AppendInittab mechanism called during initialization, to make the built-in _gdb module known to Python. */ +PyMODINIT_FUNC init__gdb_module (void); PyMODINIT_FUNC init__gdb_module (void) {