mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-12-15 04:31:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix illegal memory access when parsing corrupt DWARF information.

Browse Source 
PR 23064
	* dwarf.c (process_cu_tu_index): Test for a potential buffer
	overrun before copying signature pointer.
This commit is contained in:
Nick Clifton 2018-04-17 12:35:55 +01:00
parent c48935d75f
commit 6aea08d9f3
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
binutils/ChangeLog
View File

@ -1,3 +1,9 @@
2018-04-17 Nick Clifton <nickc@redhat.com>
PR 23064
* dwarf.c (process_cu_tu_index): Test for a potential buffer
overrun before copying signature pointer.
2018-04-17 Alan Modra <amodra@gmail.com>
* readelf.c: Revert 2018-04-16 and 2018-04-11 changes.

13
binutils/dwarf.c
View File

@ -9287,7 +9287,18 @@ process_cu_tu_index (struct dwarf_section *section, int do_display)
}
if (!do_display)
memcpy (&this_set[row - 1].signature, ph, sizeof (uint64_t));
{
size_t num_copy = sizeof (uint64_t);
/* PR 23064: Beware of buffer overflow. */
if (ph + num_copy < limit)
memcpy (&this_set[row - 1].signature, ph, num_copy);
else
{
warn (_("Signature (%p) extends beyond end of space in section\n"), ph);
return 0;
}
}
prow = poffsets + (row - 1) * ncols * 4;
/* PR 17531: file: b8ce60a8. */