mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-12-09 04:21:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

x86-64: Disallow PC reloc against weak undefined symbols in PIE

Browse Source 
Disallow PC relocations against weak undefined symbols in PIE since they
can lead to non-zero address at run-time.

bfd/

	PR ld/21782
	* elf64-x86-64.c (elf_x86_64_relocate_section): Disallow PC
	relocations against weak undefined symbols in PIE.

ld/

	PR ld/21782
	* testsuite/ld-x86-64/pie3.d: Expect linker error.
This commit is contained in:
H.J. Lu 2021-07-08 13:49:17 -07:00
parent a8dde0a211
commit 661b504df9
2 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
bfd/elf64-x86-64.c
View File

@ -3161,6 +3161,8 @@ elf_x86_64_relocate_section (bfd *output_bfd,
|| (no_copyreloc_p
&& h->def_dynamic
&& !(h->root.u.def.section->flags & SEC_CODE))))
|| (bfd_link_pie (info)
&& h->root.type == bfd_link_hash_undefweak)
|| bfd_link_dll (info)))
{
bool fail = false;
@ -3174,8 +3176,9 @@ elf_x86_64_relocate_section (bfd *output_bfd,
{
/* We can only use PC-relative relocations in PIE
from non-code sections. */
if (h->type == STT_FUNC
&& (sec->flags & SEC_CODE) != 0)
if (h->root.type == bfd_link_hash_undefweak
|| (h->type == STT_FUNC
&& (sec->flags & SEC_CODE) != 0))
fail = true;
}
else if (no_copyreloc_p || bfd_link_dll (info))

11
ld/testsuite/ld-x86-64/pie3.d
View File

@ -1,12 +1,3 @@
#as: --64
#ld: -pie -melf_x86_64 --hash-style=sysv -z max-page-size=0x200000 -z noseparate-code
#objdump: -dw
.*: +file format .*
Disassembly of section .text:
0+191 <_start>:
+191: 48 8d 05 68 fe ff ff lea -0x198\(%rip\),%rax # 0 <_start-0x191>
#pass
#error: .*relocation R_X86_64_PC32 against undefined symbol `foo' can not be used when making a PIE object; recompile with -fPIE