From 5e829a3440363ab8ceee0b7d273600ee1d1af417 Mon Sep 17 00:00:00 2001 From: Jeff Law Date: Sun, 13 Feb 1994 06:36:41 +0000 Subject: [PATCH] * elfcode.h (elf_map_symbols): Fix typo. (write_object_contents): Check return values from prep_headers and elf_compute_section_file_positions. (set_section_contents): Likewise. --- bfd/ChangeLog | 7 +++++++ bfd/elfcode.h | 14 +++++++++----- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 14c77fe8630..e8da4b9c62c 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,10 @@ +Sat Feb 12 22:34:14 1994 Jeffrey A. Law (law@snake.cs.utah.edu) + + * elfcode.h (elf_map_symbols): Fix typo. + (write_object_contents): Check return values from prep_headers and + elf_compute_section_file_positions. + (set_section_contents): Likewise. + Fri Feb 11 16:56:50 1994 David J. Mackenzie (djm@thepub.cygnus.com) * archive.c (normalize) [VMS]: Call malloc, not bfd_xmalloc. diff --git a/bfd/elfcode.h b/bfd/elfcode.h index b5c8d0b6b92..80f6272509a 100644 --- a/bfd/elfcode.h +++ b/bfd/elfcode.h @@ -1434,7 +1434,7 @@ DEFUN (elf_map_symbols, (abfd), bfd * abfd) sect_syms = (asymbol **) bfd_zalloc (abfd, max_index * sizeof (asymbol *)); elf_section_syms (abfd) = sect_syms; - if (sect_syms != 0) + if (sect_syms == 0) { bfd_error = no_memory; return false; @@ -2362,8 +2362,10 @@ DEFUN (NAME(bfd_elf,write_object_contents), (abfd), bfd * abfd) if (abfd->output_has_begun == false) { - prep_headers (abfd); - elf_compute_section_file_positions (abfd); + if (prep_headers (abfd) == false) + return false; + if (elf_compute_section_file_positions (abfd) == false) + return false; abfd->output_has_begun = true; } @@ -3192,8 +3194,10 @@ DEFUN (elf_set_section_contents, (abfd, section, location, offset, count), if (abfd->output_has_begun == false) /* set by bfd.c handler? */ { /* do setup calculations (FIXME) */ - prep_headers (abfd); - elf_compute_section_file_positions (abfd); + if (prep_headers (abfd) == false) + return false; + if (elf_compute_section_file_positions (abfd) == false) + return false; abfd->output_has_begun = true; }