mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-12-09 04:21:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdbserver/event-loop.c: type mismatch

Browse Source 
Building with C++ catches a buglet here:

../../../src/gdb/gdbserver/event-loop.c:205:19: warning: invalid conversion from ‘gdb_client_data {aka void*}’ to ‘void**’ [-fpermissive]
   event_ptr->data = data;
                   ^

This works in practice because gdb_client_data is a pointer already
(hence in C we get an implicit conversion), and nothing deferences the
pointer.  It's passed from client at event registration/creation time,
only to pass straight back to client callback.

Well, that and nothing in gdbserver uses the event data anyway.

gdb/gdbserver/ChangeLog:
2015-07-10  Pedro Alves  <palves@redhat.com>

	* event-loop.c (struct callback_event) <data>: Change type to
	gdb_client_data instance instead of gdb_client_data pointer.
	(append_callback_event): Adjust.
This commit is contained in:
Pedro Alves 2015-07-10 19:47:17 +01:00
parent 813dabb9f0
commit 58c1b36c67
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/gdbserver/ChangeLog
View File

@ -1,3 +1,9 @@
2015-07-10 Pedro Alves <palves@redhat.com>
* event-loop.c (struct callback_event) <data>: Change type to
gdb_client_data instance instead of gdb_client_data pointer.
(append_callback_event): Adjust.
2015-07-10 Pierre Langlois <pierre.langlois@arm.com>
* linux-aarch64-low.c: Add comments for each linux_target_ops

4
gdb/gdbserver/event-loop.c
View File

@ -130,7 +130,7 @@ struct callback_event
{
int id;
callback_handler_func *proc;
gdb_client_data *data;
gdb_client_data data;
struct callback_event *next;
};
@ -249,7 +249,7 @@ process_callback (void)
if (event_ptr != NULL)
{
callback_handler_func *proc = event_ptr->proc;
gdb_client_data *data = event_ptr->data;
gdb_client_data data = event_ptr->data;
/* Remove the event before calling PROC,
more events may get added by PROC. */