mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-09 04:21:49 +08:00
gdb/tui: avoid theoretical bug with 'tui reg' command
While looking at the 'tui reg' command as part of another patch, I spotted a theoretical bug. The 'tui reg' command takes the name of a register group, but also handles partial register group matches, though the partial match has to be unique. The current command logic goes: With the code as currently written, if a target description named a register group either 'prev' or 'next' then GDB would see this as an ambiguous register name, and refuse to switch groups. Naming a register group 'prev' or 'next' seems pretty unlikely, but, by adding a single else block we can prevent this problem. Now, if there's a 'prev' or 'next' register group, the user will not be able to select the group directly, the 'prev' and 'next' names will always iterate through the available groups instead. But at least the user could select their groups by iteration, rather than direct selection.
This commit is contained in:
parent
2b72890eba
commit
5783701b36
@ -580,19 +580,21 @@ tui_reg_command (const char *args, int from_tty)
|
||||
match = tui_reg_next (current_group, gdbarch);
|
||||
else if (strncmp (args, "prev", len) == 0)
|
||||
match = tui_reg_prev (current_group, gdbarch);
|
||||
|
||||
/* This loop matches on the initial part of a register group
|
||||
name. If this initial part in ARGS matches only one register
|
||||
group then the switch is made. */
|
||||
for (group = reggroup_next (gdbarch, NULL);
|
||||
group != NULL;
|
||||
group = reggroup_next (gdbarch, group))
|
||||
else
|
||||
{
|
||||
if (strncmp (reggroup_name (group), args, len) == 0)
|
||||
/* This loop matches on the initial part of a register group
|
||||
name. If this initial part in ARGS matches only one register
|
||||
group then the switch is made. */
|
||||
for (group = reggroup_next (gdbarch, NULL);
|
||||
group != NULL;
|
||||
group = reggroup_next (gdbarch, group))
|
||||
{
|
||||
if (match != NULL)
|
||||
error (_("ambiguous register group name '%s'"), args);
|
||||
match = group;
|
||||
if (strncmp (reggroup_name (group), args, len) == 0)
|
||||
{
|
||||
if (match != NULL)
|
||||
error (_("ambiguous register group name '%s'"), args);
|
||||
match = group;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user