From 576fd14c6861ef937a50b5a7500c8a58f8c4ea92 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Tue, 13 Jan 2015 18:59:32 +0400 Subject: [PATCH] gdb/testsuite: Make clean mostlyclean should not delete *.py. A sanity-check in my release scripts caught something: After having created the tarballs, I verify that no checked-in file disappeared in the process, and lo and behod, it found that the following file got wiped: - gdb/testsuite/dg-extract-results.py: And it's not part of the tarball either. I don't understand while we delete all *.py files in gdb/testsuite, since I don't see a rule that expected to create one. A run of the testsuite also doesn't seem to be creating .py files there. I traced this to the following commit, which unfortunately provided no explanation. Perhaps we used to run some tests in the gdb/testsuite directory and caused files to be left behind there. Perhaps we still do today? In the meantime, Executive Decision: In order to allow me to create tarballs without losing files, I removed it. It's easy to put something back if we find out why it might still be needed. gdb/testsuite/ChangeLog: * Makefile.in (clean mostlyclean): Do not delete *.py. Tested on x86_64-linux by running the src-release.sh script again, and this time, dg-extract-results.py no longer gets wiped. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/Makefile.in | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 868339c1a1f..4a903bccb1b 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2015-01-13 Joel Brobecker + + * Makefile.in (clean mostlyclean): Do not delete *.py. + 2015-01-13 Joel Brobecker * gdb.python/py-lookup-type.exp: New file. diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in index b319409f5ed..53cb7547d4c 100644 --- a/gdb/testsuite/Makefile.in +++ b/gdb/testsuite/Makefile.in @@ -242,7 +242,7 @@ force:; clean mostlyclean: -rm -f *~ core *.o a.out xgdb *.x *.grt bigcore.corefile .gdb_history - -rm -f core.* *.tf *.cl *.py tracecommandsscript copy1.txt zzz-gdbscript + -rm -f core.* *.tf *.cl tracecommandsscript copy1.txt zzz-gdbscript -rm -f *.dwo *.dwp -rm -rf outputs temp cache -rm -f read1.so expect-read1