mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-21 01:12:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix "obvious" fall-through warnings

Browse Source 
This patch fixes the subset of -Wimplicit-fallthrough warnings that I
considered obvious.  In most cases it was obvious from context that
falling through was desired; here I added the appropriate comment.  In
a couple of cases it seemed clear that a "break" was missing.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
	* utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
	* eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
	comment.
	* d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
	comment.
	* coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
	comment.
This commit is contained in:
Tom Tromey 2016-09-27 11:28:18 -06:00
parent 621846f4e2
commit 565e0edacc
6 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
gdb/ChangeLog
View File

@ -1,3 +1,14 @@
2018-05-04 Tom Tromey <tom@tromey.com>
* riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
* utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
* eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
comment.
* d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
comment.
* coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
comment.
2018-05-04 Tom Tromey <tom@tromey.com>
* dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.

1
gdb/coffread.c
View File

@ -928,6 +928,7 @@ coff_symtab_read (minimal_symbol_reader &reader,
backtraces, so filter them out (from phdm@macqel.be). */
if (within_function)
break;
/* Fall through. */
case C_STAT:
case C_THUMBLABEL:
case C_THUMBSTAT:

1
gdb/d-valprint.c
View File

@ -88,6 +88,7 @@ d_val_print (struct type *type, int embedded_offset,
stream, recurse, val, options);
if (ret == 0)
break;
/* Fall through. */
default:
c_val_print (type, embedded_offset, address, stream,
recurse, val, options);

1
gdb/eval.c
View File

@ -215,6 +215,7 @@ fetch_subexp_value (struct expression *exp, int *pc, struct value **valp,
case MEMORY_ERROR:
if (!preserve_errors)
break;
/* Fall through. */
default:
throw_exception (ex);
break;

1
gdb/riscv-tdep.c
View File

@ -369,6 +369,7 @@ riscv_isa_xlen (struct gdbarch *gdbarch)
{
default:
warning (_("unknown xlen size, assuming 4 bytes"));
/* Fall through. */
case 1:
return 4;
case 2:

1
gdb/utils.c
View File

@ -275,6 +275,7 @@ can_dump_core (enum resource_limit_kind limit_kind)
case LIMIT_CUR:
if (rlim.rlim_cur == 0)
return 0;
/* Fall through. */
case LIMIT_MAX:
if (rlim.rlim_max == 0)