mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-03-13 13:49:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

[gdb] Fix prop->const_val uses in gdbtypes.c

Browse Source 
After commit 66d6346b25 "gdb: remove TYPE_DYN_PROP_ADDR", I run into:
...
FAIL: gdb.fortran/class-allocatable-array.exp: print this%_data%b
...
(and 185 more FAILs, all for fortran test-cases).

The commit replaces "!x" by "x != 0".

Fix this by using "x == 0" instead.

Build and tested on x86_64-linux.

gdb/ChangeLog:

2020-08-05  Tom de Vries  <tdevries@suse.de>

	* gdbtypes.c (type_not_allocated, type_not_associated): Use
	"prop->const_val () == 0" instead of "prop->const_val () != 0".
This commit is contained in:
Tom de Vries 2020-08-05 12:31:58 +02:00
parent 787bbc56d8
commit 5555c86d3e
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2020-08-05 Tom de Vries <tdevries@suse.de>
* gdbtypes.c (type_not_allocated, type_not_associated): Use
"prop->const_val () == 0" instead of "prop->const_val () != 0".
2020-08-04 Simon Marchi <simon.marchi@efficios.com>
* frame.h (frame_id_p): Return bool.

4
gdb/gdbtypes.c
View File

@ -4134,7 +4134,7 @@ type_not_allocated (const struct type *type)
struct dynamic_prop *prop = TYPE_ALLOCATED_PROP (type);
return (prop != nullptr && prop->kind () == PROP_CONST
&& prop->const_val () != 0);
&& prop->const_val () == 0);
}
/* Associated status of type TYPE. Return zero if type TYPE is associated.
@ -4146,7 +4146,7 @@ type_not_associated (const struct type *type)
struct dynamic_prop *prop = TYPE_ASSOCIATED_PROP (type);
return (prop != nullptr && prop->kind () == PROP_CONST
&& prop->const_val () != 0);
&& prop->const_val () == 0);
}
/* rank_one_type helper for when PARM's type code is TYPE_CODE_PTR. */