mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-21 01:12:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

opcodes/arm: adjust whitespace in cpsie instruction

Browse Source 
While I was working on the disassembler styling for ARM I noticed that
the whitespace in the cpsie instruction was inconsistent with most of
the other ARM disassembly output, the disassembly for cpsie looks like
this:

  cpsie   if,#10

notice there's no space before the '#10' immediate, most other ARM
instructions have a space before each operand.

This commit updates the disassembler to add the missing space, and
updates the tests I found that tested this instruction.
This commit is contained in:
Andrew Burgess 2023-02-28 21:40:17 +00:00
parent 71f18376db
commit 4fc808ae2a
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gas/testsuite/gas/arm/archv6.d
View File

@ -219,7 +219,7 @@ Disassembly of section .text:
0+34c <[^>]*> e6ef2475 ? uxtb r2, r5, ror #8
0+350 <[^>]*> 16ef2075 ? uxtbne r2, r5
0+354 <[^>]*> 16ef2475 ? uxtbne r2, r5, ror #8
0+358 <[^>]*> f10a00ca ? cpsie if,#10
0+35c <[^>]*> f10a00d5 ? cpsie if,#21
0+358 <[^>]*> f10a00ca ? cpsie if, #10
0+35c <[^>]*> f10a00d5 ? cpsie if, #21
0+360 <[^>]*> f8cd0510 ? srsia sp, #16
0+364 <[^>]*> f9ed0510 ? srsib sp!, #16

4
gas/testsuite/gas/arm/t16-bad.s
View File

@ -131,8 +131,8 @@ l:
@ Miscellaneous
bkpt #257
cpsie ai,#5
cpsid ai,#5
cpsie ai, #5
cpsid ai, #5
@ Conditional suffixes
addeq r0,r1,r2

4
opcodes/arm-dis.c
View File

@ -3828,11 +3828,11 @@ static const struct opcode32 arm_opcodes[] =
{ARM_FEATURE_CORE_LOW (ARM_EXT_V6),
0xf1080000, 0xfffffe3f, "cpsie\t%{B:%8'a%7'i%6'f%}"},
{ARM_FEATURE_CORE_LOW (ARM_EXT_V6),
0xf10a0000, 0xfffffe20, "cpsie\t%{B:%8'a%7'i%6'f%},%{I:#%0-4d%}"},
0xf10a0000, 0xfffffe20, "cpsie\t%{B:%8'a%7'i%6'f%}, %{I:#%0-4d%}"},
{ARM_FEATURE_CORE_LOW (ARM_EXT_V6),
0xf10C0000, 0xfffffe3f, "cpsid\t%{B:%8'a%7'i%6'f%}"},
{ARM_FEATURE_CORE_LOW (ARM_EXT_V6),
0xf10e0000, 0xfffffe20, "cpsid\t%{B:%8'a%7'i%6'f%},%{I:#%0-4d%}"},
0xf10e0000, 0xfffffe20, "cpsid\t%{B:%8'a%7'i%6'f%}, %{I:#%0-4d%}"},
{ARM_FEATURE_CORE_LOW (ARM_EXT_V6),
0xf1000000, 0xfff1fe20, "cps\t%{I:#%0-4d%}"},
{ARM_FEATURE_CORE_LOW (ARM_EXT_V6),