gdb: add intern methods to objfile_per_bfd_storage

This allows keeping the objfile_per_bfd_storage implementation details
into objfile_per_bfd_storage, instead of into objfile.  And this makes
the intern methods usable for code that only has an
objfile_per_bfd_storage to work with.

gdb/ChangeLog:

	* objfiles.h (struct objfile_per_bfd_storage) <intern>: New
	methods.
	(struct objfile) <intern>: Use
	objfile::objfile_per_bfd_storage::intern.

Change-Id: Ifd54026c5efaeffafac9b84ff84c199acc7ce78a
This commit is contained in:
Simon Marchi 2021-04-02 11:23:52 -04:00
parent 0672875f3c
commit 4a4f97c129
2 changed files with 26 additions and 3 deletions

View File

@ -1,3 +1,10 @@
2021-04-02 Simon Marchi <simon.marchi@polymtl.ca>
* objfiles.h (struct objfile_per_bfd_storage) <intern>: New
methods.
(struct objfile) <intern>: Use
objfile::objfile_per_bfd_storage::intern.
2021-04-01 Simon Marchi <simon.marchi@efficios.com>
* gdbtypes.h (TYPE_FLAG_ENUM): Remove, replace all uses

View File

@ -270,6 +270,23 @@ struct objfile_per_bfd_storage
~objfile_per_bfd_storage ();
/* Intern STRING in this object's string cache and return the unique copy.
The copy has the same lifetime as this object.
STRING must be null-terminated. */
const char *intern (const char *str)
{
return (const char *) string_cache.insert (str, strlen (str) + 1);
}
/* Same as the above, but for an std::string. */
const char *intern (const std::string &str)
{
return (const char *) string_cache.insert (str.c_str (), str.size () + 1);
}
/* The storage has an obstack of its own. */
auto_obstack storage_obstack;
@ -516,15 +533,14 @@ struct objfile
lifetime as the per-BFD object. */
const char *intern (const char *str)
{
return (const char *) per_bfd->string_cache.insert (str, strlen (str) + 1);
return per_bfd->intern (str);
}
/* Intern STRING and return the unique copy. The copy has the same
lifetime as the per-BFD object. */
const char *intern (const std::string &str)
{
return (const char *) per_bfd->string_cache.insert (str.c_str (),
str.size () + 1);
return per_bfd->intern (str);
}
/* Retrieve the gdbarch associated with this objfile. */