mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-02-17 13:10:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

sim: bpf: add explicit casts when using explicit formats

Browse Source 
Since the value variable usually has an incompatible type for the wide
variety of types it is printed as, add explicit casts to them all.
This commit is contained in:
Mike Frysinger 2021-06-26 22:05:04 -04:00
parent cc9c19b030
commit 44e88cd631
2 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sim/bpf/ChangeLog
View File

@ -1,3 +1,7 @@
2021-06-27 Mike Frysinger <vapier@gentoo.org>
* bpf-helpers.c (bpf_trace_printk): Add casts to every value printf.
2021-06-27 Mike Frysinger <vapier@gentoo.org>
* bpf-helpers.c (bpf_trace_printk): Move value decl to top of scope.

24
sim/bpf/bpf-helpers.c
View File

@ -95,16 +95,16 @@ bpf_trace_printk (SIM_CPU *current_cpu)
fmt_address + i)))
{
case 'd':
trace_printf (sd, current_cpu, "%d", value);
trace_printf (sd, current_cpu, "%d", (int) value);
break;
case 'i':
trace_printf (sd, current_cpu, "%i", value);
trace_printf (sd, current_cpu, "%i", (int) value);
break;
case 'u':
trace_printf (sd, current_cpu, "%u", value);
trace_printf (sd, current_cpu, "%u", (unsigned int) value);
break;
case 'x':
trace_printf (sd, current_cpu, "%x", value);
trace_printf (sd, current_cpu, "%x", (unsigned int) value);
break;
case 'l':
{
@ -114,16 +114,16 @@ bpf_trace_printk (SIM_CPU *current_cpu)
fmt_address + i))
{
case 'd':
trace_printf (sd, current_cpu, "%ld", value);
trace_printf (sd, current_cpu, "%ld", (long) value);
break;
case 'i':
trace_printf (sd, current_cpu, "%li", value);
trace_printf (sd, current_cpu, "%li", (long) value);
break;
case 'u':
trace_printf (sd, current_cpu, "%lu", value);
trace_printf (sd, current_cpu, "%lu", (unsigned long) value);
break;
case 'x':
trace_printf (sd, current_cpu, "%lx", value);
trace_printf (sd, current_cpu, "%lx", (unsigned long) value);
break;
case 'l':
{
@ -132,16 +132,16 @@ bpf_trace_printk (SIM_CPU *current_cpu)
switch (GETMEMUQI (current_cpu, CPU_PC_GET (current_cpu),
fmt_address + i)) {
case 'd':
trace_printf (sd, current_cpu, "%lld", value);
trace_printf (sd, current_cpu, "%lld", (long long) value);
break;
case 'i':
trace_printf (sd, current_cpu, "%lli", value);
trace_printf (sd, current_cpu, "%lli", (long long) value);
break;
case 'u':
trace_printf (sd, current_cpu, "%llu", value);
trace_printf (sd, current_cpu, "%llu", (unsigned long long) value);
break;
case 'x':
trace_printf (sd, current_cpu, "%llx", value);
trace_printf (sd, current_cpu, "%llx", (unsigned long long) value);
break;
default:
assert (0);