mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-12-15 04:31:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix two buglets in cp_print_value_fields patch

Browse Source 
Pedro and Tom both pointed out issues in the cp_print_value_fields
patch, aka the fix for PR c++/20020.

This patch addresses both issues.  Tested on x86-64 Fedora 29.

gdb/ChangeLog
2019-06-27  Tom Tromey  <tromey@adacore.com>

	* cp-valprint.c (cp_print_value_fields): Pass opts, not options,
	to cp_print_static_field.

gdb/testsuite/ChangeLog
2019-06-27  Tom Tromey  <tromey@adacore.com>

	* gdb.cp/constexpr-field.exp: Use setup_xfail.
This commit is contained in:
Tom Tromey 2019-06-18 09:37:02 -06:00
parent ba85f98c42
commit 3d507ff23b
4 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2019-06-27 Tom Tromey <tromey@adacore.com>
* cp-valprint.c (cp_print_value_fields): Pass opts, not options,
to cp_print_static_field.
2019-06-26 Tom Tromey <tromey@adacore.com>
* minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.

2
gdb/cp-valprint.c
View File

@ -302,7 +302,7 @@ cp_print_value_fields (struct type *type, struct type *real_type,
cp_print_static_field (TYPE_FIELD_TYPE (type, i),
v, stream, recurse + 1,
options);
opts);
}
catch (const gdb_exception_error &ex)
{

4
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,7 @@
2019-06-27 Tom Tromey <tromey@adacore.com>
* gdb.cp/constexpr-field.exp: Use setup_xfail.
2019-06-26 Tom de Vries <tdevries@suse.de>
* gdb.dwarf2/varval.exp: Compile twice, once without bad DWARF.

3
gdb/testsuite/gdb.cp/constexpr-field.exp
View File

@ -31,6 +31,7 @@ if {![runto_main]} {
# "x" sometimes isn't available due to
# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90526
gdb_test "print x" " = {static f = .*}"
setup_xfail *-*-* gcc/90526
gdb_test "print x" " = {static f = true}"
gdb_test "print y" " = {static f = true}"