mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-02-05 12:53:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove stale "register" bits from gdb.cp/misc.cc

Browse Source 
gdb.cp/misc.cc seems to have been originally copied from
gdb.cp/classes.cc.  The testcases that use it, misc.exp and
inherit.exp don't reference the "register" bits anywhere.  Remove
them, since they trigger warnings with newer GCCs, given "register" is
being removed in C++17.

gdb/testsuite/ChangeLog:

	* gdb.cp/inherit.exp: No longer pass -Wno-deprecated-register.
	* gdb.cp/misc.exp: No longer pass -Wno-deprecated-register.
	* gdb.cp/misc.cc (class small, small::method, marker_reg1)
	(register_class): Delete.
	(main): Don't call register_class.
This commit is contained in:
Pedro Alves 2020-08-22 18:00:55 +01:00
parent d5f96005a6
commit 3b8d4c5cc0
4 changed files with 10 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,11 @@
2020-09-13 Pedro Alves <pedro@palves.net>
* gdb.cp/inherit.exp: No longer pass -Wno-deprecated-register.
* gdb.cp/misc.exp: No longer pass -Wno-deprecated-register.
* gdb.cp/misc.cc (class small, small::method, marker_reg1)
(register_class): Delete.
(main): Don't call register_class.
2020-09-13 Pedro Alves <pedro@palves.net>
* gdb.cp/classes.exp: No longer pass -Wno-deprecated-register.

3
gdb/testsuite/gdb.cp/inherit.exp
View File

@ -26,8 +26,7 @@ load_lib "cp-support.exp"
standard_testfile misc.cc
if {[prepare_for_testing "failed to prepare" $testfile $srcfile \
{debug c++ additional_flags=-Wno-deprecated-register}]} {
if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} {
return -1
}

37
gdb/testsuite/gdb.cp/misc.cc
View File

@ -511,42 +511,6 @@ typedef struct {
} tagless_struct;
tagless_struct v_tagless;
/* Try to get the compiler to allocate a class in a register. */
class small {
public:
int x;
int method ();
};
int
small::method ()
{
return x + 5;
}
void marker_reg1 () {}
int
register_class ()
{
/* We don't call any methods for v, so gcc version cygnus-2.3.3-930220
might put this variable in a register. This is a lose, though, because
it means that GDB can't call any methods for that variable. */
register small v;
int i;
/* Perform a computation sufficiently complicated that optimizing compilers
won't optimized out the variable. If some compiler constant-folds this
whole loop, maybe using a parameter to this function here would help. */
v.x = 0;
for (i = 0; i < 13; ++i)
v.x += i;
--v.x; /* v.x is now 77 */
marker_reg1 ();
return v.x + 5;
}
void dummy()
{
v_bool = true;
@ -574,7 +538,6 @@ main()
inheritance1 ();
inheritance3 ();
enums1 ();
register_class ();
/* FIXME: pmi gets optimized out. Need to do some more computation with
it or something. (No one notices, because the test is xfail'd anyway,

3
gdb/testsuite/gdb.cp/misc.exp
View File

@ -19,8 +19,7 @@ if { [skip_cplus_tests] } { continue }
standard_testfile .cc
if {[prepare_for_testing "failed to prepare" $testfile $srcfile \
{debug c++ additional_flags=-Wno-deprecated-register}]} {
if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} {
return -1
}