[gdb] Mention --with/without-system-readline for --configuration

Simon reported that the new test-case gdb.tui/pr30056.exp fails with system
readline.

This is because the test-case requires a fix in readline that's present in our
in-repo copy of readline, but most likely not in any system readline yet.

Fix this by:
- mentioning --with-system-readline or --without-system-readline in the
  configuration string.
- adding a new proc with_system_readline that makes this information available
  in the testsuite.
- using this in test-case gdb.tui/pr30056.exp to declare it unsupported for
  --with-system-readline.

Tested on x86_64-linux.

Reported-By: Simon Marchi <simon.marchi@efficios.com>
Approved-By: Simon Marchi <simon.marchi@efficios.com>
This commit is contained in:
Tom de Vries 2023-05-30 17:49:31 +02:00
parent 35f8b0595f
commit 37d9880d65
3 changed files with 22 additions and 0 deletions

View File

@ -15,6 +15,10 @@
# Regression test for PR30056.
# This PR is fixed in the in-repo copy of readline. System readline may or
# may not be fixed, so skip this test-case.
require !with_system_readline
tuiterm_env
save_vars { env(LC_ALL) } {

View File

@ -2565,6 +2565,14 @@ gdb_caching_proc allow_python_tests {} {
return [expr {[string first "--with-python" $output] != -1}]
}
# Return a 1 for configurations that use system readline rather than the
# in-repo copy.
gdb_caching_proc with_system_readline {} {
set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configuration"]
return [expr {[string first "--with-system-readline" $output] != -1}]
}
gdb_caching_proc allow_dap_tests {} {
if { ![allow_python_tests] } {
return 0

View File

@ -1560,6 +1560,16 @@ This GDB was configured as follows:\n\
"));
#endif
#ifdef HAVE_READLINE_READLINE_H
gdb_printf (stream, _("\
--with-system-readline\n\
"));
#else
gdb_printf (stream, _("\
--without-system-readline\n\
"));
#endif
#ifdef RELOC_SRCDIR
gdb_printf (stream, _("\
--with-relocated-sources=%s\n\